Skip to content

Commit bce3c06

Browse files
authored
remove check for custom endpoints (#2288)
1 parent 5bd505f commit bce3c06

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

native/core/src/parquet/objectstore/s3.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,6 @@ pub fn create_store(
6868
}
6969
let path = Path::parse(path)?;
7070

71-
if configs.contains_key("fs.s3a.endpoint") {
72-
return Err(object_store::Error::NotSupported {
73-
source: "Custom S3 endpoints are not supported".into(),
74-
});
75-
}
76-
7771
let mut builder = AmazonS3Builder::new()
7872
.with_url(url.to_string())
7973
.with_allow_http(true);

spark/src/test/scala/org/apache/comet/objectstore/NativeConfigSuite.scala

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -117,17 +117,6 @@ class NativeConfigSuite extends AnyFunSuite with Matchers with BeforeAndAfterEac
117117
assert(e.getMessage.contains(expectedError))
118118
}
119119

120-
test("validate object store config - custom s3 endpoint not supported") {
121-
val hadoopConf = new Configuration()
122-
hadoopConf.set("fs.s3a.endpoint", "https://acme.storage.com")
123-
val e = intercept[CometNativeException] {
124-
validate(hadoopConf)
125-
}
126-
val expectedError =
127-
"Custom S3 endpoints are not supported"
128-
assert(e.getMessage.contains(expectedError))
129-
}
130-
131120
test("validity cache") {
132121
val hadoopConf = new Configuration()
133122
hadoopConf.set("fs.s3a.endpoint", "https://acme.storage.com")

0 commit comments

Comments
 (0)