Skip to content

Commit c1b4b86

Browse files
committed
Revert widen changes
1 parent 42f58f8 commit c1b4b86

File tree

2 files changed

+22
-19
lines changed

2 files changed

+22
-19
lines changed

spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ import org.apache.comet.CometConf
5353
import org.apache.comet.CometSparkSessionExtensions.isSpark40Plus
5454
import org.apache.comet.rules.CometScanTypeChecker
5555

56+
@nowarn("cat=w-flag-numeric-widen")
5657
abstract class ParquetReadSuite extends CometTestBase {
5758
import testImplicits._
5859

@@ -417,15 +418,15 @@ abstract class ParquetReadSuite extends CometTestBase {
417418
opt match {
418419
case Some(i) =>
419420
record.add(0, i % 2 == 0)
420-
record.add(1, i.toByte.toInt)
421-
record.add(2, i.toShort.toInt)
421+
record.add(1, i.toByte)
422+
record.add(2, i.toShort)
422423
record.add(3, i)
423424
record.add(4, i.toLong)
424425
record.add(5, i.toFloat)
425426
record.add(6, i.toDouble)
426427
record.add(7, i.toString * 48)
427-
record.add(8, (-i).toByte.toInt)
428-
record.add(9, (-i).toShort.toInt)
428+
record.add(8, (-i).toByte)
429+
record.add(9, (-i).toShort)
429430
record.add(10, -i)
430431
record.add(11, (-i).toLong)
431432
record.add(12, i.toString)
@@ -640,8 +641,8 @@ abstract class ParquetReadSuite extends CometTestBase {
640641
opt match {
641642
case Some(i) =>
642643
record.add(0, i % 2 == 0)
643-
record.add(1, i.toByte.toInt)
644-
record.add(2, i.toShort.toInt)
644+
record.add(1, i.toByte)
645+
record.add(2, i.toShort)
645646
record.add(3, i)
646647
record.add(4, i.toLong)
647648
record.add(5, i.toFloat)
@@ -1580,14 +1581,14 @@ abstract class ParquetReadSuite extends CometTestBase {
15801581
case Some(i) =>
15811582
record.add(0, i % 2 == 0)
15821583
record.add(1, i.toByte)
1583-
record.add(2, i.toShort.toInt)
1584+
record.add(2, i.toShort)
15841585
record.add(3, i)
15851586
record.add(4, i.toLong)
15861587
record.add(5, i.toFloat)
15871588
record.add(6, i.toDouble)
15881589
record.add(7, i.toString * 48)
1589-
record.add(8, (-i).toByte.toInt)
1590-
record.add(9, (-i).toShort.toInt)
1590+
record.add(8, (-i).toByte)
1591+
record.add(9, (-i).toShort)
15911592
record.add(10, -i)
15921593
record.add(11, (-i).toLong)
15931594
record.add(12, i.toString)
@@ -1676,7 +1677,7 @@ abstract class ParquetReadSuite extends CometTestBase {
16761677
val record = new SimpleGroup(schema)
16771678
opt match {
16781679
case Some(i) =>
1679-
record.add(0, i.toShort.toInt)
1680+
record.add(0, i.toShort)
16801681
record.add(1, i)
16811682
record.add(2, i.toLong)
16821683
case _ =>

spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,7 @@ abstract class CometTestBase
553553
dictionaryPageSize: Int = 1024,
554554
pageRowCountLimit: Int = ParquetProperties.DEFAULT_PAGE_ROW_COUNT_LIMIT,
555555
rowGroupSize: Long = 1024 * 1024L): ParquetWriter[Group] = {
556+
556557
val hadoopConf = spark.sessionState.newHadoopConf()
557558
ExampleParquetWriter
558559
.builder(path)
@@ -641,6 +642,7 @@ abstract class CometTestBase
641642
}
642643
}
643644

645+
@nowarn("cat=w-flag-numeric-widen")
644646
def makeParquetFileAllPrimitiveTypes(
645647
path: Path,
646648
dictionaryEnabled: Boolean,
@@ -676,15 +678,15 @@ abstract class CometTestBase
676678
opt match {
677679
case Some(i) =>
678680
record.add(0, i % 2 == 0)
679-
record.add(1, i.toByte.toInt)
680-
record.add(2, i.toShort.toInt)
681+
record.add(1, i.toByte)
682+
record.add(2, i.toShort)
681683
record.add(3, i)
682684
record.add(4, i.toLong)
683685
record.add(5, i.toFloat)
684686
record.add(6, i.toDouble)
685687
record.add(7, i.toString * 48)
686-
record.add(8, (-i).toByte.toInt)
687-
record.add(9, (-i).toShort.toInt)
688+
record.add(8, (-i).toByte)
689+
record.add(9, (-i).toShort)
688690
record.add(10, -i)
689691
record.add(11, (-i).toLong)
690692
record.add(12, i.toString)
@@ -705,15 +707,15 @@ abstract class CometTestBase
705707
val i = rand.nextLong()
706708
val record = new SimpleGroup(schema)
707709
record.add(0, i % 2 == 0)
708-
record.add(1, i.toByte.toInt)
709-
record.add(2, i.toShort.toInt)
710-
record.add(3, i.toInt)
710+
record.add(1, i.toByte)
711+
record.add(2, i.toShort)
712+
record.add(3, i)
711713
record.add(4, i)
712714
record.add(5, java.lang.Float.intBitsToFloat(i.toInt))
713715
record.add(6, java.lang.Double.longBitsToDouble(i))
714716
record.add(7, i.toString * 24)
715-
record.add(8, (-i).toByte.toInt)
716-
record.add(9, (-i).toShort.toInt)
717+
record.add(8, (-i).toByte)
718+
record.add(9, (-i).toShort)
717719
record.add(10, (-i).toInt)
718720
record.add(11, -i)
719721
record.add(12, i.toString)

0 commit comments

Comments
 (0)