fix: Make Sha2 fallback message more user-friendly (#2213)

rishvin · web-flow · commit d93931f518d8 · 2025-08-26T11:48:23.000-07:00
diff --git a/spark/src/main/scala/org/apache/comet/serde/hash.scala b/spark/src/main/scala/org/apache/comet/serde/hash.scala
@@ -75,7 +75,7 @@ object CometSha2 extends CometExpressionSerde[Sha2] {
     // It's possible for spark to dynamically compute the number of bits from input
     // expression, however DataFusion does not support that yet.
     if (!expr.right.foldable) {
-      withInfo(expr, "For Sha2, non-foldable right argument is not supported")
+      withInfo(expr, "For Sha2, non literal numBits is not supported")
       return None
     }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ object CometSha2 extends CometExpressionSerde[Sha2] {`
`75`	`75`	`// It's possible for spark to dynamically compute the number of bits from input`
`76`	`76`	`// expression, however DataFusion does not support that yet.`
`77`	`77`	`if (!expr.right.foldable) {`
`78`		`- withInfo(expr, "For Sha2, non-foldable right argument is not supported")`
	`78`	`+ withInfo(expr, "For Sha2, non literal numBits is not supported")`
`79`	`79`	`return None`
`80`	`80`	`}`
`81`	`81`