Skip to content

Commit e4e1148

Browse files
compheadcomphead
authored
chore: Fallback to Spark for windows functions (#2726)
1 parent f807c63 commit e4e1148

File tree

149 files changed

+382
-387
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

149 files changed

+382
-387
lines changed

‎spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1125,6 +1125,9 @@ object QueryPlanSerde extends Logging with CometExprShim {
11251125

11261126
case WindowExec(windowExpression, partitionSpec, orderSpec, child)
11271127
if CometConf.COMET_EXEC_WINDOW_ENABLED.get(conf) =>
1128+
withInfo(op, "Window expressions are not supported")
1129+
None
1130+
/*
11281131
val output = child.output
11291132
11301133
val winExprs: Array[WindowExpression] = windowExpression.flatMap { expr =>
@@ -1165,7 +1168,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
11651168
Some(builder.setWindow(windowBuilder).build())
11661169
} else {
11671170
None
1168-
}
1171+
} */
11691172

11701173
case aggregate: BaseAggregateExec
11711174
if (aggregate.isInstanceOf[HashAggregateExec] ||

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q12.native_iceberg_compat/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject [COMET: ]
22
+- Project
3-
+- Window
3+
+- Window [COMET: Window expressions are not supported]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q12/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject [COMET: ]
22
+- Project
3-
+- Window
3+
+- Window [COMET: Window expressions are not supported]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q20.native_iceberg_compat/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject [COMET: ]
22
+- Project
3-
+- Window
3+
+- Window [COMET: Window expressions are not supported]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q20/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject [COMET: ]
22
+- Project
3-
+- Window
3+
+- Window [COMET: Window expressions are not supported]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q36.native_iceberg_compat/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject [COMET: ]
22
+- Project
3-
+- Window
3+
+- Window [COMET: Window expressions are not supported]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q36/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject [COMET: ]
22
+- Project
3-
+- Window
3+
+- Window [COMET: Window expressions are not supported]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q47.native_iceberg_compat/extended.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
: : +- Filter
88
: : +- Window
99
: : +- Filter
10-
: : +- Window
10+
: : +- Window [COMET: Window expressions are not supported]
1111
: : +- CometColumnarToRow
1212
: : +- CometSort
1313
: : +- CometExchange
@@ -39,7 +39,7 @@
3939
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
4040
: +- BroadcastExchange
4141
: +- Project
42-
: +- Window
42+
: +- Window [COMET: Window expressions are not supported]
4343
: +- CometColumnarToRow
4444
: +- CometSort
4545
: +- CometExchange
@@ -71,7 +71,7 @@
7171
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
7272
+- BroadcastExchange
7373
+- Project
74-
+- Window
74+
+- Window [COMET: Window expressions are not supported]
7575
+- CometColumnarToRow
7676
+- CometSort
7777
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q47/extended.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
: : +- Filter
88
: : +- Window
99
: : +- Filter
10-
: : +- Window
10+
: : +- Window [COMET: Window expressions are not supported]
1111
: : +- CometColumnarToRow
1212
: : +- CometSort
1313
: : +- CometExchange
@@ -39,7 +39,7 @@
3939
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
4040
: +- BroadcastExchange
4141
: +- Project
42-
: +- Window
42+
: +- Window [COMET: Window expressions are not supported]
4343
: +- CometColumnarToRow
4444
: +- CometSort
4545
: +- CometExchange
@@ -71,7 +71,7 @@
7171
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
7272
+- BroadcastExchange
7373
+- Project
74-
+- Window
74+
+- Window [COMET: Window expressions are not supported]
7575
+- CometColumnarToRow
7676
+- CometSort
7777
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q49.native_iceberg_compat/extended.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ CometColumnarToRow
88
: +- Filter
99
: +- Window
1010
: +- Sort
11-
: +- Window
11+
: +- Window [COMET: Window expressions are not supported]
1212
: +- CometColumnarToRow
1313
: +- CometSort
1414
: +- CometExchange
@@ -40,7 +40,7 @@ CometColumnarToRow
4040
: +- Filter
4141
: +- Window
4242
: +- Sort
43-
: +- Window
43+
: +- Window [COMET: Window expressions are not supported]
4444
: +- CometColumnarToRow
4545
: +- CometSort
4646
: +- CometExchange
@@ -67,7 +67,7 @@ CometColumnarToRow
6767
+- Filter
6868
+- Window
6969
+- Sort
70-
+- Window
70+
+- Window [COMET: Window expressions are not supported]
7171
+- CometColumnarToRow
7272
+- CometSort
7373
+- CometExchange

0 commit comments

Comments
 (0)