Skip to content

Commit e684cf8

Browse files
authored
Enable plan stability tests (#2516)
1 parent 07393c1 commit e684cf8

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ trait CometPlanStabilitySuite extends DisableAdaptiveExecutionSuite with TPCDSBa
248248
CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "true",
249249
CometConf.COMET_ENABLED.key -> "true",
250250
CometConf.COMET_NATIVE_SCAN_ENABLED.key -> "true",
251+
CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_AUTO,
251252
CometConf.COMET_EXEC_ENABLED.key -> "true",
252253
CometConf.COMET_DPP_FALLBACK_ENABLED.key -> "false",
253254
CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
@@ -283,8 +284,6 @@ trait CometPlanStabilitySuite extends DisableAdaptiveExecutionSuite with TPCDSBa
283284
conf.set(MEMORY_OFFHEAP_SIZE.key, "2g")
284285
conf.set(CometConf.COMET_ENABLED.key, "true")
285286
conf.set(CometConf.COMET_EXEC_ENABLED.key, "true")
286-
conf.set(CometConf.COMET_NATIVE_SCAN_ENABLED.key, "true")
287-
conf.set(CometConf.COMET_NATIVE_SCAN_IMPL.key, CometConf.SCAN_AUTO)
288287
conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "1g")
289288
conf.set(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, "true")
290289

@@ -303,11 +302,9 @@ class CometTPCDSV1_4_PlanStabilitySuite extends CometPlanStabilitySuite {
303302
override val goldenFilePath: String =
304303
new File(baseResourcePath, planName).getAbsolutePath
305304

306-
if (CometConf.COMET_NATIVE_SCAN_IMPL.get() == CometConf.SCAN_AUTO) {
307-
tpcdsQueries.foreach { q =>
308-
test(s"check simplified (tpcds-v1.4/$q)") {
309-
testQuery("tpcds", q)
310-
}
305+
tpcdsQueries.foreach { q =>
306+
test(s"check simplified (tpcds-v1.4/$q)") {
307+
testQuery("tpcds", q)
311308
}
312309
}
313310
}
@@ -323,11 +320,9 @@ class CometTPCDSV2_7_PlanStabilitySuite extends CometPlanStabilitySuite {
323320
override val goldenFilePath: String =
324321
new File(baseResourcePath, planName).getAbsolutePath
325322

326-
if (CometConf.COMET_NATIVE_SCAN_IMPL.get() == CometConf.SCAN_AUTO) {
327-
tpcdsQueriesV2_7_0.foreach { q =>
328-
test(s"check simplified (tpcds-v2.7.0/$q)") {
329-
testQuery("tpcds-v2.7.0", q)
330-
}
323+
tpcdsQueriesV2_7_0.foreach { q =>
324+
test(s"check simplified (tpcds-v2.7.0/$q)") {
325+
testQuery("tpcds-v2.7.0", q)
331326
}
332327
}
333328
}

0 commit comments

Comments
 (0)