Skip to content

chore: deprecate native_comet scan in favor of native_iceberg_compat #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Shekharrajak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: deprecate native_comet scan in favor of native_iceberg_compat #2949

Shekharrajak wants to merge 3 commits into from

Conversation

@Shekharrajak
Copy link
Contributor

@Shekharrajak Shekharrajak commented Dec 20, 2025 •
edited
Loading

Add deprecation annotation to SCAN_NATIVE_COMET and update documentation to recommend native_iceberg_compat. The legacy scan uses mutable buffers incompatible with Arrow FFI best practices.

Ref #2949

andygrove
andygrove reviewed Dec 20, 2025
View reviewed changes
@coderfender
Copy link
Contributor

coderfender commented Dec 22, 2025 •
edited
Loading

@Shekharrajak , please run make format to format the code and that should pass the builds

@Shekharrajak
Copy link
Contributor Author

Shekharrajak commented Dec 26, 2025

@Shekharrajak , please run make format to format the code and that should pass the builds

This is done already.

@coderfender
Copy link
Contributor

coderfender commented Dec 26, 2025

@Shekharrajak , seems like the formatting is still an issue ?

error file=/__w/datafusion-comet/datafusion-comet/common/src/main/scala/org/apache/comet/CometConf.scala message=File line length exceeds 100 characters line=128
error file=/__w/datafusion-comet/datafusion-comet/common/src/main/scala/org/apache/comet/CometConf.scala message=File line length exceeds 100 characters line=130
error file=/__w/datafusion-comet/datafusion-comet/common/src/main/scala/org/apache/comet/CometConf.scala message=File line length exceeds 100 characters line=131
error file=/__w/datafusion-comet/datafusion-comet/common/src/main/scala/org/apache/comet/CometConf.scala message=File line length exceeds 100 characters line=132

@coderfender
Copy link
Contributor

coderfender commented Dec 26, 2025

@Shekharrajak could also please link the issue you are closing so that there is no duplicate work associated?

@Shekharrajak
Copy link
Contributor Author

Shekharrajak commented Dec 27, 2025

Ref #2949

comment native_iceberg_compat

@coderfender
Copy link
Contributor

coderfender commented Dec 27, 2025

Thank you

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.59%. Comparing base (f09f8af) to head (e9f3e29).
⚠️ Report is 839 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2949      +/-   ##
============================================
+ Coverage     56.12%   59.59%   +3.46%     
- Complexity      976     1377     +401     
============================================
  Files           119      167      +48     
  Lines         11743    15496    +3753     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9235    +2644     
- Misses         4012     4962     +950     
- Partials       1140     1299     +159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove left review comments

+1 more reviewer

@coderfender coderfender coderfender left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shekharrajak @coderfender @codecov-commenter @andygrove