Skip to content

Commit 00bd445

Browse files
committed
refactor: update documentation for DataFrame to Table Provider conversion
1 parent a8275dc commit 00bd445

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/dataframe.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -397,11 +397,12 @@ impl PyDataFrame {
397397
PyArrowType(self.df.schema().into())
398398
}
399399

400-
/// Convert this DataFrame into a Table that can be used in register_table
400+
/// Convert this DataFrame into a Table Provider that can be used in register_table
401401
/// By convention, into_... methods consume self and return the new object.
402-
/// Here we intentionally borrow to avoid invalidating the Python wrapper.
403-
/// https://github.com/apache/datafusion-python/pull/1016#discussion_r1983239116
404-
/// - we have not decided on the table_provider approach yet
402+
/// Disabling the clippy lint, so we can use &self
403+
/// because we're working with Python bindings
404+
/// where objects are shared
405+
#[allow(clippy::wrong_self_convention)]
405406
pub fn into_view(&self) -> PyDataFusionResult<PyTableProvider> {
406407
// Call the underlying Rust DataFrame::into_view method.
407408
// Note that the Rust method consumes self; here we clone the inner Arc<DataFrame>

0 commit comments

Comments
 (0)