Enabled ruff rule ICN001

Author: Spaarsh

pyproject.toml

@@ -102,7 +102,7 @@ ignore = [
     # "EM102",
     "ERA001",
     # "SIM108",
-    "ICN001",
+    # "ICN001",
     "ANN001",
     "ANN202",
     "PTH",

python/datafusion/context.py

@@ -40,9 +40,9 @@
 if TYPE_CHECKING:
     import pathlib
 
-    import pandas
-    import polars
-    import pyarrow
+    import pandas as pd
+    import polars as pl
+    import pyarrow as pa
 
     from datafusion.plan import ExecutionPlan, LogicalPlan
 
@@ -537,7 +537,7 @@ def register_listing_table(
         path: str | pathlib.Path,
         table_partition_cols: list[tuple[str, str]] | None = None,
         file_extension: str = ".parquet",
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         file_sort_order: list[list[Expr | SortExpr]] | None = None,
     ) -> None:
         """Register multiple files as a single table.
@@ -606,14 +606,14 @@ def sql_with_options(self, query: str, options: SQLOptions) -> DataFrame:
 
     def create_dataframe(
         self,
-        partitions: list[list[pyarrow.RecordBatch]],
+        partitions: list[list[pa.RecordBatch]],
         name: str | None = None,
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
     ) -> DataFrame:
         """Create and return a dataframe using the provided partitions.
 
         Args:
-            partitions: :py:class:`pyarrow.RecordBatch` partitions to register.
+            partitions: :py:class:`pa.RecordBatch` partitions to register.
             name: Resultant dataframe name.
             schema: Schema for the partitions.
 
@@ -684,16 +684,14 @@ def from_arrow(
         return DataFrame(self.ctx.from_arrow(data, name))
 
     @deprecated("Use ``from_arrow`` instead.")
-    def from_arrow_table(
-        self, data: pyarrow.Table, name: str | None = None
-    ) -> DataFrame:
+    def from_arrow_table(self, data: pa.Table, name: str | None = None) -> DataFrame:
         """Create a :py:class:`~datafusion.dataframe.DataFrame` from an Arrow table.
 
         This is an alias for :py:func:`from_arrow`.
         """
         return self.from_arrow(data, name)
 
-    def from_pandas(self, data: pandas.DataFrame, name: str | None = None) -> DataFrame:
+    def from_pandas(self, data: pd.DataFrame, name: str | None = None) -> DataFrame:
         """Create a :py:class:`~datafusion.dataframe.DataFrame` from a Pandas DataFrame.
 
         Args:
@@ -705,7 +703,7 @@ def from_pandas(self, data: pandas.DataFrame, name: str | None = None) -> DataFr
         """
         return DataFrame(self.ctx.from_pandas(data, name))
 
-    def from_polars(self, data: polars.DataFrame, name: str | None = None) -> DataFrame:
+    def from_polars(self, data: pl.DataFrame, name: str | None = None) -> DataFrame:
         """Create a :py:class:`~datafusion.dataframe.DataFrame` from a Polars DataFrame.
 
         Args:
@@ -755,7 +753,7 @@ def register_table_provider(
         self.ctx.register_table_provider(name, provider)
 
     def register_record_batches(
-        self, name: str, partitions: list[list[pyarrow.RecordBatch]]
+        self, name: str, partitions: list[list[pa.RecordBatch]]
     ) -> None:
         """Register record batches as a table.
 
@@ -776,7 +774,7 @@ def register_parquet(
         parquet_pruning: bool = True,
         file_extension: str = ".parquet",
         skip_metadata: bool = True,
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         file_sort_order: list[list[SortExpr]] | None = None,
     ) -> None:
         """Register a Parquet file as a table.
@@ -817,7 +815,7 @@ def register_csv(
         self,
         name: str,
         path: str | pathlib.Path | list[str | pathlib.Path],
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         has_header: bool = True,
         delimiter: str = ",",
         schema_infer_max_records: int = 1000,
@@ -863,7 +861,7 @@ def register_json(
         self,
         name: str,
         path: str | pathlib.Path,
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         schema_infer_max_records: int = 1000,
         file_extension: str = ".json",
         table_partition_cols: list[tuple[str, str]] | None = None,
@@ -901,7 +899,7 @@ def register_avro(
         self,
         name: str,
         path: str | pathlib.Path,
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         file_extension: str = ".avro",
         table_partition_cols: list[tuple[str, str]] | None = None,
     ) -> None:
@@ -923,8 +921,8 @@ def register_avro(
             name, str(path), schema, file_extension, table_partition_cols
         )
 
-    def register_dataset(self, name: str, dataset: pyarrow.dataset.Dataset) -> None:
-        """Register a :py:class:`pyarrow.dataset.Dataset` as a table.
+    def register_dataset(self, name: str, dataset: pa.dataset.Dataset) -> None:
+        """Register a :py:class:`pa.dataset.Dataset` as a table.
 
         Args:
             name: Name of the table to register.
@@ -975,7 +973,7 @@ def session_id(self) -> str:
     def read_json(
         self,
         path: str | pathlib.Path,
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         schema_infer_max_records: int = 1000,
         file_extension: str = ".json",
         table_partition_cols: list[tuple[str, str]] | None = None,
@@ -1012,7 +1010,7 @@ def read_json(
     def read_csv(
         self,
         path: str | pathlib.Path | list[str] | list[pathlib.Path],
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         has_header: bool = True,
         delimiter: str = ",",
         schema_infer_max_records: int = 1000,
@@ -1065,7 +1063,7 @@ def read_parquet(
         parquet_pruning: bool = True,
         file_extension: str = ".parquet",
         skip_metadata: bool = True,
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         file_sort_order: list[list[Expr | SortExpr]] | None = None,
     ) -> DataFrame:
         """Read a Parquet source into a :py:class:`~datafusion.dataframe.Dataframe`.
@@ -1110,7 +1108,7 @@ def read_parquet(
     def read_avro(
         self,
         path: str | pathlib.Path,
-        schema: pyarrow.Schema | None = None,
+        schema: pa.Schema | None = None,
         file_partition_cols: list[tuple[str, str]] | None = None,
         file_extension: str = ".avro",
     ) -> DataFrame: