noqa rules updates per ruff checks

Author: timsaucer

pyproject.toml

@@ -77,7 +77,7 @@ max-doc-length = 88
 
 # Disable docstring checking for these directories
 [tool.ruff.lint.per-file-ignores]
-"python/tests/*" = ["ANN", "ARG", "D", "S101", "SLF", "PD"]
+"python/tests/*" = ["ANN", "ARG", "D", "S101", "SLF", "PD", "PLR2004", "RUF015"]
 "examples/*" = ["D", "W505"]
 "dev/*" = ["D"]
 "benchmarks/*" = ["D", "F"]

python/tests/test_aggregation.py

@@ -299,7 +299,7 @@ def test_aggregate_100(df_aggregate_100, name, expr, expected):
 ]
 
 
-@pytest.mark.parametrize("name,expr,result", data_test_bitwise_and_boolean_functions)
+@pytest.mark.parametrize(("name","expr","result"), data_test_bitwise_and_boolean_functions)
 def test_bit_and_bool_fns(df, name, expr, result):
     df = df.aggregate([], [expr.alias(name)])
 

python/tests/test_imports.py

@@ -169,14 +169,14 @@ def test_class_module_is_datafusion():
 
 
 def test_import_from_functions_submodule():
-    from datafusion.functions import abs, sin  # noqa
+    from datafusion.functions import abs, sin  # noqa: A004
 
     assert functions.abs is abs
     assert functions.sin is sin
 
     msg = "cannot import name 'foobar' from 'datafusion.functions'"
     with pytest.raises(ImportError, match=msg):
-        from datafusion.functions import foobar  # noqa
+        from datafusion.functions import foobar  # noqa: F401
 
 
 def test_classes_are_inheritable():

python/tests/test_udaf.py

@@ -86,7 +86,7 @@ def test_errors(df):
         "evaluate, merge, update)"
     )
     with pytest.raises(Exception, match=msg):
-        accum = udaf(  # noqa F841
+        accum = udaf(  # noqa: F841
             MissingMethods,
             pa.int64(),
             pa.int64(),

python/tests/test_udwf.py

@@ -298,7 +298,7 @@ def test_udwf_errors(df):
 ]
 
 
-@pytest.mark.parametrize("name,expr,expected", data_test_udwf_functions)
+@pytest.mark.parametrize(("name","expr","expected"), data_test_udwf_functions)
 def test_udwf_functions(df, name, expr, expected):
     df = df.select("a", "b", f.round(expr, lit(3)).alias(name))