clippy

Author: chenkovsky

src/expr/copy_to.rs

@@ -72,15 +72,15 @@ impl PyCopyTo {
         file_type: PyFileType,
         options: HashMap<String, String>,
     ) -> Self {
-        return PyCopyTo {
+        PyCopyTo {
             copy: CopyTo {
                 input: input.plan(),
                 output_url,
                 partition_by,
                 file_type: file_type.file_type,
                 options,
             },
-        };
+        }
     }
 
     fn input(&self) -> PyLogicalPlan {

src/expr/create_external_table.rs

@@ -97,7 +97,7 @@ impl PyCreateExternalTable {
                 .map(|(k, v)| (k, v.into()))
                 .collect(),
         };
-        PyCreateExternalTable { create: create }
+        PyCreateExternalTable { create }
     }
 
     pub fn schema(&self) -> PyDFSchema {
@@ -176,7 +176,7 @@ impl LogicalNode for PyCreateExternalTable {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/create_function.rs

@@ -176,7 +176,7 @@ impl LogicalNode for PyCreateFunction {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/describe_table.rs

@@ -69,7 +69,7 @@ impl LogicalNode for PyDescribeTable {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/dml.rs

@@ -29,7 +29,7 @@ impl LogicalNode for PyDmlStatement {
         vec![PyLogicalPlan::from((*self.dml.input).clone())]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/drop_catalog_schema.rs

@@ -93,7 +93,7 @@ impl LogicalNode for PyDropCatalogSchema {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/drop_function.rs

@@ -40,7 +40,7 @@ impl PyDropFunction {
     fn new(name: String, schema: PyDFSchema, if_exists: bool) -> PyResult<Self> {
         Ok(PyDropFunction {
             drop: DropFunction {
-                name: name.into(),
+                name,
                 schema: Arc::new(schema.into()),
                 if_exists,
             },
@@ -72,7 +72,7 @@ impl LogicalNode for PyDropFunction {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/drop_view.rs

@@ -79,7 +79,7 @@ impl LogicalNode for PyDropView {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/recursive_query.rs

@@ -88,7 +88,7 @@ impl LogicalNode for PyRecursiveQuery {
         ]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }

src/expr/statement.rs

@@ -33,7 +33,7 @@ impl LogicalNode for PyTransactionStart {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }
@@ -166,7 +166,7 @@ impl LogicalNode for PyTransactionEnd {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }
@@ -241,7 +241,7 @@ impl LogicalNode for PySetVariable {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }
@@ -289,7 +289,7 @@ impl LogicalNode for PyPrepare {
         vec![PyLogicalPlan::from((*self.prepare.input).clone())]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }
@@ -301,7 +301,7 @@ impl PyPrepare {
         let input = input.plan().clone();
         let data_types = data_types
             .into_iter()
-            .map(|data_type| data_type.try_into().unwrap())
+            .map(|data_type| data_type.into())
             .collect();
         PyPrepare {
             prepare: Prepare {
@@ -357,7 +357,7 @@ impl LogicalNode for PyExecute {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }
@@ -368,7 +368,7 @@ impl PyExecute {
     pub fn new(name: String, parameters: Vec<PyExpr>) -> Self {
         let parameters = parameters
             .into_iter()
-            .map(|parameter| parameter.try_into().unwrap())
+            .map(|parameter| parameter.into())
             .collect();
         PyExecute {
             execute: Execute { name, parameters },
@@ -414,7 +414,7 @@ impl LogicalNode for PyDeallocate {
         vec![]
     }
 
-    fn to_variant<'py>(&self, py: Python<'py>) -> PyResult<PyObject> {
+    fn to_variant(&self, py: Python<'_>) -> PyResult<PyObject> {
         Ok(self.clone().into_py(py))
     }
 }