fix ruff errors

Author: kosiew

python/datafusion/__init__.py

@@ -21,24 +21,26 @@
 See https://datafusion.apache.org/python for more information.
 """
 
+# isort: skip_file  # Prevent import-sorting linter errors (I001)
+# ruff: noqa: I001
+
 from __future__ import annotations
 
 from typing import Any
 
 try:
     import importlib.metadata as importlib_metadata
 except ImportError:
-    import importlib_metadata
+    import importlib_metadata  # type: ignore[import]
 
+# Public submodules
 from . import functions, object_store, substrait, unparser
 
 # The following imports are okay to remain as opaque to the user.
 from ._internal import Config, EXPECTED_PROVIDER_MSG
 from .catalog import Catalog, Database, Table
 from .col import col, column
-from .common import (
-    DFSchema,
-)
+from .common import DFSchema
 from .context import (
     RuntimeEnvBuilder,
     SessionConfig,
@@ -47,10 +49,7 @@
 )
 from .dataframe import DataFrame, ParquetColumnOptions, ParquetWriterOptions
 from .dataframe_formatter import configure_formatter
-from .expr import (
-    Expr,
-    WindowFrame,
-)
+from .expr import Expr, WindowFrame
 from .io import read_avro, read_csv, read_json, read_parquet
 from .plan import ExecutionPlan, LogicalPlan
 from .record_batch import RecordBatch, RecordBatchStream

python/datafusion/context.py

@@ -29,11 +29,10 @@
 
 import pyarrow as pa
 
-from datafusion.catalog import Catalog, CatalogProvider, Table
+from datafusion.catalog import Catalog
 from datafusion.dataframe import DataFrame
-from datafusion.expr import SortKey, sort_list_to_raw_sort_list
+from datafusion.expr import sort_list_to_raw_sort_list
 from datafusion.record_batch import RecordBatchStream
-from datafusion.user_defined import AggregateUDF, ScalarUDF, TableFunction, WindowUDF
 from datafusion.utils import _normalize_table_provider
 
 from ._internal import RuntimeEnvBuilder as RuntimeEnvBuilderInternal
@@ -50,7 +49,15 @@
     import polars as pl  # type: ignore[import]
 
     from datafusion import TableProvider
+    from datafusion.catalog import CatalogProvider, Table
+    from datafusion.expr import SortKey
     from datafusion.plan import ExecutionPlan, LogicalPlan
+    from datafusion.user_defined import (
+        AggregateUDF,
+        ScalarUDF,
+        TableFunction,
+        WindowUDF,
+    )
 
 
 class ArrowStreamExportable(Protocol):
@@ -735,7 +742,7 @@ def from_polars(self, data: pl.DataFrame, name: str | None = None) -> DataFrame:
     # https://github.com/apache/datafusion-python/pull/1016#discussion_r1983239116
     # is the discussion on how we arrived at adding register_view
     def register_view(self, name: str, df: DataFrame) -> None:
-        """Register a :py:class: `~datafusion.detaframe.DataFrame` as a view.
+        """Register a :py:class:`~datafusion.dataframe.DataFrame` as a view.
 
         Args:
             name (str): The name to register the view under.
@@ -747,8 +754,7 @@ def register_view(self, name: str, df: DataFrame) -> None:
     def register_table(
         self, name: str, table: Table | TableProvider | TableProviderExportable
     ) -> None:
-        """Register a :py:class:`~datafusion.catalog.Table` or
-        :py:class:`~datafusion.TableProvider`.
+        """Register a Table or TableProvider.
 
         The registered table can be referenced from SQL statements executed against
         this context.

python/datafusion/expr.py

@@ -25,23 +25,24 @@
 import typing as _typing
 from typing import TYPE_CHECKING, Any, ClassVar, Iterable, Optional, Sequence
 
-import pyarrow as pa
-
 try:
     from warnings import deprecated  # Python 3.13+
 except ImportError:
     from typing_extensions import deprecated  # Python 3.12
 
-from datafusion.common import NullTreatment
+import pyarrow as pa
 
 from ._internal import expr as expr_internal
 from ._internal import functions as functions_internal
 
 if TYPE_CHECKING:
     from collections.abc import Sequence
 
-    # Type-only imports
-    from datafusion.common import DataTypeMap, RexType
+    from datafusion.common import (  # type: ignore[import]
+        DataTypeMap,
+        NullTreatment,
+        RexType,
+    )
     from datafusion.plan import LogicalPlan
 
 

python/datafusion/io.py

@@ -22,13 +22,13 @@
 from typing import TYPE_CHECKING
 
 from datafusion.context import SessionContext
-from datafusion.dataframe import DataFrame
 
 if TYPE_CHECKING:
     import pathlib
 
     import pyarrow as pa
 
+    from datafusion.dataframe import DataFrame
     from datafusion.expr import Expr
 
 

python/datafusion/table_provider.py

@@ -67,10 +67,7 @@ def from_dataframe(cls, df: Any) -> TableProvider:
         """
         from datafusion.dataframe import DataFrame as DataFrameWrapper
 
-        if isinstance(df, DataFrameWrapper):
-            dataframe = df
-        else:
-            dataframe = DataFrameWrapper(df)
+        dataframe = df if isinstance(df, DataFrameWrapper) else DataFrameWrapper(df)
 
         return dataframe.into_view()
 

python/datafusion/utils.py

@@ -60,7 +60,6 @@ def _normalize_table_provider(
     Raises:
         TypeError: If ``table`` is not a supported table provider input.
     """
-
     from datafusion.catalog import Table as _Table
     from datafusion.table_provider import TableProvider as _TableProvider