Skip to content

Commit d0c3163

Browse files
committed
refactor: simplify as_table method and update documentation for into_view
1 parent ca42449 commit d0c3163

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/dataframe.rs

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,9 @@ impl PyTableProvider {
6262
Self { provider }
6363
}
6464

65-
pub fn get_provider(&self) -> Arc<dyn TableProvider> {
66-
self.provider.clone()
67-
}
68-
69-
/// Convert this TableProvider into a concrete Table wrapper, if possible.
7065
pub fn as_table(&self) -> PyDataFusionResult<PyTable> {
71-
// Here, you’d write the logic to convert your inner Arc<dyn TableProvider>
72-
// to a PyTable (which is a Python–exposed concrete table type).
73-
let table: Arc<dyn TableProvider> = self.provider.clone();
74-
// Convert the trait object into your PyTable wrapper (if you have one)
75-
Ok(PyTable::new(table))
66+
let table_provider: Arc<dyn TableProvider> = self.provider.clone();
67+
Ok(PyTable::new(table_provider))
7668
}
7769
}
7870

@@ -115,7 +107,7 @@ impl PyDataFrame {
115107
}
116108
}
117109

118-
/// Convert this DataFrame into a view (i.e. a TableProvider) that can be registered.
110+
/// Convert this DataFrame into a Table that can be used in register_table
119111
fn into_view(&self) -> PyDataFusionResult<PyTable> {
120112
// Call the underlying Rust DataFrame::into_view method.
121113
// Note that the Rust method consumes self; here we clone the inner Arc<DataFrame>

0 commit comments

Comments
 (0)