refactor: rename into_view method to _into_view

Author: kosiew

python/datafusion/dataframe.py

@@ -123,7 +123,11 @@ def __init__(self, df: DataFrameInternal) -> None:
 
     def into_view(self) -> pa.Table:
         """Convert DataFrame as a ViewTable which can be used in register_table."""
-        return self.df.into_view()
+        return self._into_view()
+    
+    def _into_view(self) -> pa.Table:
+        """Convert DataFrame as a ViewTable which can be used in register_table."""
+        return self.df._into_view()
 
     def __getitem__(self, key: str | List[str]) -> DataFrame:
         """Return a new :py:class`DataFrame` with the specified column or columns.

src/dataframe.rs

@@ -62,9 +62,9 @@ impl PyTableProvider {
         Self { provider }
     }
 
-    pub fn as_table(&self) -> PyDataFusionResult<PyTable> {
+    pub fn as_table(&self) -> PyTable {
         let table_provider: Arc<dyn TableProvider> = self.provider.clone();
-        Ok(PyTable::new(table_provider))
+        PyTable::new(table_provider)
     }
 }
 
@@ -107,17 +107,6 @@ impl PyDataFrame {
         }
     }
 
-    /// Convert this DataFrame into a Table that can be used in register_table
-    fn into_view(&self) -> PyDataFusionResult<PyTable> {
-        // Call the underlying Rust DataFrame::into_view method.
-        // Note that the Rust method consumes self; here we clone the inner Arc<DataFrame>
-        // so that we don’t invalidate this PyDataFrame.
-        let table_provider = self.df.as_ref().clone().into_view();
-        let table_provider = PyTableProvider::new(table_provider);
-
-        Ok(table_provider.as_table()?)
-    }
-
     fn __repr__(&self, py: Python) -> PyDataFusionResult<String> {
         let df = self.df.as_ref().clone().limit(0, Some(10))?;
         let batches = wait_for_future(py, df.collect())?;
@@ -185,6 +174,20 @@ impl PyDataFrame {
         PyArrowType(self.df.schema().into())
     }
 
+    /// Convert this DataFrame into a Table that can be used in register_table
+    fn _into_view(&self) -> PyDataFusionResult<PyTable> {
+        // Call the underlying Rust DataFrame::into_view method.
+        // Note that the Rust method consumes self; here we clone the inner Arc<DataFrame>
+        // so that we don’t invalidate this PyDataFrame.
+        // _into_view because clippy says `into_*` usually take `self` by value
+        // but we cannot own self because Python objects are shared,
+        // so 'self' cannot be moved out of the Python interpreter
+        let table_provider = self.df.as_ref().clone().into_view();
+        let table_provider = PyTableProvider::new(table_provider);
+
+        Ok(table_provider.as_table())
+    }
+
     #[pyo3(signature = (*args))]
     fn select_columns(&self, args: Vec<PyBackedStr>) -> PyDataFusionResult<Self> {
         let args = args.iter().map(|s| s.as_ref()).collect::<Vec<&str>>();