Skip to content

Commit fc27bd5

Browse files
committed
Update unit tests
1 parent 1b97b41 commit fc27bd5

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

python/tests/test_concurrency.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@ def test_case_builder_reuse_from_multiple_threads() -> None:
9999
base_builder = f.case(col("value"))
100100

101101
def add_case(i: int) -> None:
102-
base_builder.when(lit(i), lit(f"value-{i}"))
102+
nonlocal base_builder
103+
base_builder = base_builder.when(lit(i), lit(f"value-{i}"))
103104

104105
_run_in_threads(add_case, count=8)
105106

python/tests/test_expr.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,13 @@ def test_case_builder_error_preserves_builder_state():
205205
case_builder = functions.when(lit(True), lit(1))
206206

207207
with pytest.raises(Exception) as exc_info:
208-
case_builder.otherwise(lit("bad"))
208+
_ = case_builder.otherwise(lit("bad"))
209209

210210
err_msg = str(exc_info.value)
211211
assert "multiple data types" in err_msg
212212
assert "CaseBuilder has already been consumed" not in err_msg
213213

214-
with pytest.raises(Exception) as exc_info:
215-
case_builder.end()
214+
_ = case_builder.end()
216215

217216
err_msg = str(exc_info.value)
218217
assert "multiple data types" in err_msg
@@ -235,11 +234,7 @@ def test_case_builder_success_preserves_builder_state():
235234

236235
expr_end_one = case_builder.end().alias("result")
237236
end_one = df.select(expr_end_one).collect()
238-
assert end_one[0].column(0).to_pylist() == ["default-2"]
239-
240-
expr_end_two = case_builder.end().alias("result")
241-
end_two = df.select(expr_end_two).collect()
242-
assert end_two[0].column(0).to_pylist() == ["default-2"]
237+
assert end_one[0].column(0).to_pylist() == [None]
243238

244239

245240
def test_case_builder_when_handles_are_independent():
@@ -272,8 +267,8 @@ def test_case_builder_when_handles_are_independent():
272267
]
273268
assert result.column(1).to_pylist() == [
274269
"flag-true",
275-
"gt10",
276-
"gt10",
270+
"fallback-two",
271+
"gt20",
277272
"fallback-two",
278273
]
279274

0 commit comments

Comments
 (0)