Fix regression on register_udaf #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Sep 20, 2024
7 tasks
|
Looks like a small difference on the captured exception string, will try to address soon |
|
I thought it was weird that it was passing for Python 3.12 but failed for prior versions. Python 3.12 did change the way missing abstract methods are reported. Issue: python/cpython#98284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #874
Rationale for this change
datafusion-python41.1.0 introduced a regression onSessionContext.register_udaf. This two line change corrects it.What changes are included in this PR?
Correct regression.
Adds unit test for registering udaf and udf.
Are there any user-facing changes?
None