Skip to content

Commit 02ecfe5

Browse files
aharpervcaharpervc
committed
Add OR ALTER support for CREATE FUNCTION 
1 parent f3af75f commit 02ecfe5

File tree

5 files changed

+105
-3
lines changed

5 files changed

+105
-3
lines changed

‎src/ast/ddl.rs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2157,6 +2157,10 @@ impl fmt::Display for ClusteredBy {
21572157
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
21582158
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
21592159
pub struct CreateFunction {
2160+
/// True if this is a `CREATE OR ALTER FUNCTION` statement
2161+
///
2162+
/// [MsSql](https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver16#or-alter)
2163+
pub or_alter: bool,
21602164
pub or_replace: bool,
21612165
pub temporary: bool,
21622166
pub if_not_exists: bool,
@@ -2219,9 +2223,10 @@ impl fmt::Display for CreateFunction {
22192223
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
22202224
write!(
22212225
f,
2222-
"CREATE {or_replace}{temp}FUNCTION {if_not_exists}{name}",
2226+
"CREATE {or_alter}{or_replace}{temp}FUNCTION {if_not_exists}{name}",
22232227
name = self.name,
22242228
temp = if self.temporary { "TEMPORARY " } else { "" },
2229+
or_alter = if self.or_alter { "OR ALTER " } else { "" },
22252230
or_replace = if self.or_replace { "OR REPLACE " } else { "" },
22262231
if_not_exists = if self.if_not_exists {
22272232
"IF NOT EXISTS "

‎src/parser/mod.rs‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4555,7 +4555,7 @@ impl<'a> Parser<'a> {
45554555
} else if self.parse_keyword(Keyword::EXTERNAL) {
45564556
self.parse_create_external_table(or_replace)
45574557
} else if self.parse_keyword(Keyword::FUNCTION) {
4558-
self.parse_create_function(or_replace, temporary)
4558+
self.parse_create_function(or_alter, or_replace, temporary)
45594559
} else if self.parse_keyword(Keyword::TRIGGER) {
45604560
self.parse_create_trigger(or_replace, false)
45614561
} else if self.parse_keywords(&[Keyword::CONSTRAINT, Keyword::TRIGGER]) {
@@ -4864,6 +4864,7 @@ impl<'a> Parser<'a> {
48644864

48654865
pub fn parse_create_function(
48664866
&mut self,
4867+
or_alter: bool,
48674868
or_replace: bool,
48684869
temporary: bool,
48694870
) -> Result<Statement, ParserError> {
@@ -4876,7 +4877,7 @@ impl<'a> Parser<'a> {
48764877
} else if dialect_of!(self is BigQueryDialect) {
48774878
self.parse_bigquery_create_function(or_replace, temporary)
48784879
} else if dialect_of!(self is MsSqlDialect) {
4879-
self.parse_mssql_create_function(or_replace, temporary)
4880+
self.parse_mssql_create_function(or_alter, or_replace, temporary)
48804881
} else {
48814882
self.prev_token();
48824883
self.expected("an object type after CREATE", self.peek_token())
@@ -4991,6 +4992,7 @@ impl<'a> Parser<'a> {
49914992
}
49924993

49934994
Ok(Statement::CreateFunction(CreateFunction {
4995+
or_alter: false,
49944996
or_replace,
49954997
temporary,
49964998
name,
@@ -5024,6 +5026,7 @@ impl<'a> Parser<'a> {
50245026
let using = self.parse_optional_create_function_using()?;
50255027

50265028
Ok(Statement::CreateFunction(CreateFunction {
5029+
or_alter: false,
50275030
or_replace,
50285031
temporary,
50295032
name,
@@ -5113,6 +5116,7 @@ impl<'a> Parser<'a> {
51135116
};
51145117

51155118
Ok(Statement::CreateFunction(CreateFunction {
5119+
or_alter: false,
51165120
or_replace,
51175121
temporary,
51185122
if_not_exists,
@@ -5136,6 +5140,7 @@ impl<'a> Parser<'a> {
51365140
/// [MsSql]: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql
51375141
fn parse_mssql_create_function(
51385142
&mut self,
5143+
or_alter: bool,
51395144
or_replace: bool,
51405145
temporary: bool,
51415146
) -> Result<Statement, ParserError> {
@@ -5179,6 +5184,7 @@ impl<'a> Parser<'a> {
51795184
let function_body = Some(CreateFunctionBody::MultiStatement(result));
51805185

51815186
Ok(Statement::CreateFunction(CreateFunction {
5187+
or_alter,
51825188
or_replace,
51835189
temporary,
51845190
if_not_exists: false,

‎tests/sqlparser_bigquery.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2134,6 +2134,7 @@ fn test_bigquery_create_function() {
21342134
assert_eq!(
21352135
stmt,
21362136
Statement::CreateFunction(CreateFunction {
2137+
or_alter: false,
21372138
or_replace: true,
21382139
temporary: true,
21392140
if_not_exists: false,

‎tests/sqlparser_mssql.rs‎

Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ fn parse_create_function() {
193193
assert_eq!(
194194
ms().verified_stmt(return_expression_function),
195195
sqlparser::ast::Statement::CreateFunction(CreateFunction {
196+
or_alter: false,
196197
or_replace: false,
197198
temporary: false,
198199
if_not_exists: false,
@@ -255,6 +256,93 @@ fn parse_create_function() {
255256
assert_eq!(
256257
ms().verified_stmt(multi_statement_function),
257258
sqlparser::ast::Statement::CreateFunction(CreateFunction {
259+
or_alter: false,
260+
or_replace: false,
261+
temporary: false,
262+
if_not_exists: false,
263+
name: ObjectName::from(vec![Ident {
264+
value: "some_scalar_udf".into(),
265+
quote_style: None,
266+
span: Span::empty(),
267+
}]),
268+
args: Some(vec![
269+
OperateFunctionArg {
270+
mode: None,
271+
name: Some(Ident {
272+
value: "@foo".into(),
273+
quote_style: None,
274+
span: Span::empty(),
275+
}),
276+
data_type: DataType::Int(None),
277+
default_expr: None,
278+
},
279+
OperateFunctionArg {
280+
mode: None,
281+
name: Some(Ident {
282+
value: "@bar".into(),
283+
quote_style: None,
284+
span: Span::empty(),
285+
}),
286+
data_type: DataType::Varchar(Some(CharacterLength::IntegerLength {
287+
length: 256,
288+
unit: None
289+
})),
290+
default_expr: None,
291+
},
292+
]),
293+
return_type: Some(DataType::Int(None)),
294+
function_body: Some(CreateFunctionBody::MultiStatement(vec![
295+
Statement::Set(Set::SingleAssignment {
296+
scope: None,
297+
hivevar: false,
298+
variable: ObjectName::from(vec!["@foo".into()]),
299+
values: vec![sqlparser::ast::Expr::BinaryOp {
300+
left: Box::new(sqlparser::ast::Expr::Identifier(Ident {
301+
value: "@foo".to_string(),
302+
quote_style: None,
303+
span: Span::empty(),
304+
})),
305+
op: sqlparser::ast::BinaryOperator::Plus,
306+
right: Box::new(Expr::Value(
307+
(Value::Number("1".into(), false)).with_empty_span()
308+
)),
309+
}],
310+
}),
311+
Statement::Return(ReturnStatement {
312+
value: Some(ReturnStatementValue::Expr(Expr::Identifier(Ident {
313+
value: "@foo".into(),
314+
quote_style: None,
315+
span: Span::empty(),
316+
}))),
317+
}),
318+
])),
319+
behavior: None,
320+
called_on_null: None,
321+
parallel: None,
322+
using: None,
323+
language: None,
324+
determinism_specifier: None,
325+
options: None,
326+
remote_connection: None,
327+
}),
328+
);
329+
}
330+
331+
#[test]
332+
fn parse_mssql_create_function() {
333+
let create_or_alter_function = "\
334+
CREATE OR ALTER FUNCTION some_scalar_udf(@foo INT, @bar VARCHAR(256)) \
335+
RETURNS INT \
336+
AS \
337+
BEGIN \
338+
SET @foo = @foo + 1; \
339+
RETURN @foo \
340+
END\
341+
";
342+
assert_eq!(
343+
ms().verified_stmt(create_or_alter_function),
344+
sqlparser::ast::Statement::CreateFunction(CreateFunction {
345+
or_alter: true,
258346
or_replace: false,
259347
temporary: false,
260348
if_not_exists: false,

‎tests/sqlparser_postgres.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4104,6 +4104,7 @@ fn parse_create_function() {
41044104
assert_eq!(
41054105
pg_and_generic().verified_stmt(sql),
41064106
Statement::CreateFunction(CreateFunction {
4107+
or_alter: false,
41074108
or_replace: false,
41084109
temporary: false,
41094110
name: ObjectName::from(vec![Ident::new("add")]),
@@ -5485,6 +5486,7 @@ fn parse_trigger_related_functions() {
54855486
assert_eq!(
54865487
create_function,
54875488
Statement::CreateFunction(CreateFunction {
5489+
or_alter: false,
54885490
or_replace: false,
54895491
temporary: false,
54905492
if_not_exists: false,

0 commit comments

Comments
 (0)