pretty-print CREATE VIEW statements (#1855)

lovasoa · web-flow · commit 3f4d5f96ee26 · 2025-05-21T05:44:33.000+02:00
diff --git a/src/ast/mod.rs b/src/ast/mod.rs
@@ -4858,7 +4858,9 @@ impl fmt::Display for Statement {
                 if matches!(options, CreateTableOptions::Options(_)) {
                     write!(f, " {options}")?;
                 }
-                write!(f, " AS {query}")?;
+                f.write_str(" AS")?;
+                SpaceOrNewline.fmt(f)?;
+                query.fmt(f)?;
                 if *with_no_schema_binding {
                     write!(f, " WITH NO SCHEMA BINDING")?;
                 }
diff --git a/tests/pretty_print.rs b/tests/pretty_print.rs
@@ -264,7 +264,6 @@ CREATE TABLE my_table (
 }
 
 #[test]
-#[ignore = "https://github.com/apache/datafusion-sqlparser-rs/issues/1850"]
 fn test_pretty_print_create_view() {
     assert_eq!(
         prettify("CREATE VIEW my_view AS SELECT a, b FROM my_table WHERE x > 0"),

Original file line number	Diff line number	Diff line change
`@@ -4858,7 +4858,9 @@ impl fmt::Display for Statement {`
`4858`	`4858`	`if matches!(options, CreateTableOptions::Options(_)) {`
`4859`	`4859`	`write!(f, " {options}")?;`
`4860`	`4860`	`}`
`4861`		`- write!(f, " AS {query}")?;`
	`4861`	`+ f.write_str(" AS")?;`
	`4862`	`+ SpaceOrNewline.fmt(f)?;`
	`4863`	`+ query.fmt(f)?;`
`4862`	`4864`	`if *with_no_schema_binding {`
`4863`	`4865`	`write!(f, " WITH NO SCHEMA BINDING")?;`
`4864`	`4866`	`}`
Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,6 @@ CREATE TABLE my_table (`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`#[test]`
`267`		`-#[ignore = "https://github.com/apache/datafusion-sqlparser-rs/issues/1850"]`
`268`	`267`	`fn test_pretty_print_create_view() {`
`269`	`268`	`assert_eq!(`
`270`	`269`	`prettify("CREATE VIEW my_view AS SELECT a, b FROM my_table WHERE x > 0"),`