pr feedback: generic naming for syntax

Author: achristmascarl

src/ast/ddl.rs

@@ -352,8 +352,11 @@ pub enum AlterTableOperation {
         name: Ident,
     },
     /// `SET ( storage_parameter [= value] [, ... ] )`
-    SetStorageParameters {
-        storage_parameters: Vec<SqlOption>,
+    ///
+    /// Note: this is a PostgreSQL-specific operation.
+    /// Please refer to [PostgreSQL documentation](https://www.postgresql.org/docs/current/sql-altertable.html)
+    SetOptionsParens {
+        options: Vec<SqlOption>,
     },
 }
 
@@ -795,8 +798,8 @@ impl fmt::Display for AlterTableOperation {
             AlterTableOperation::ValidateConstraint { name } => {
                 write!(f, "VALIDATE CONSTRAINT {name}")
             }
-            AlterTableOperation::SetStorageParameters { storage_parameters } => {
-                write!(f, "SET ({})", display_comma_separated(storage_parameters))
+            AlterTableOperation::SetOptionsParens { options } => {
+                write!(f, "SET ({})", display_comma_separated(options))
             }
         }
     }

src/ast/spans.rs

@@ -1201,8 +1201,8 @@ impl Spanned for AlterTableOperation {
             AlterTableOperation::Lock { .. } => Span::empty(),
             AlterTableOperation::ReplicaIdentity { .. } => Span::empty(),
             AlterTableOperation::ValidateConstraint { name } => name.span,
-            AlterTableOperation::SetStorageParameters { storage_parameters } => {
-                union_spans(storage_parameters.iter().map(|i| i.span()))
+            AlterTableOperation::SetOptionsParens { options } => {
+                union_spans(options.iter().map(|i| i.span()))
             }
         }
     }

src/parser/mod.rs

@@ -8947,9 +8947,7 @@ impl<'a> Parser<'a> {
             } else {
                 options = self.parse_options(Keyword::SET)?;
                 if !options.is_empty() {
-                    AlterTableOperation::SetStorageParameters {
-                        storage_parameters: options,
-                    }
+                    AlterTableOperation::SetOptionsParens { options }
                 } else {
                     return self.expected(
                     "ADD, RENAME, PARTITION, SWAP, DROP, REPLICA IDENTITY, SET, or SET TBLPROPERTIES after ALTER TABLE",

tests/sqlparser_common.rs

@@ -4728,9 +4728,9 @@ fn parse_alter_table() {
 
     let set_storage_parameters = "ALTER TABLE tab SET (autovacuum_vacuum_scale_factor = 0.01, autovacuum_vacuum_threshold = 500)";
     match alter_table_op(verified_stmt(set_storage_parameters)) {
-        AlterTableOperation::SetStorageParameters { storage_parameters } => {
+        AlterTableOperation::SetOptionsParens { options } => {
             assert_eq!(
-                storage_parameters,
+                options,
                 [
                     SqlOption::KeyValue {
                         key: Ident {