Code review comments

Author: yoavcloud

src/ast/mod.rs

@@ -4413,7 +4413,7 @@ impl fmt::Display for Statement {
                     let keyword = match &db_name_keyword {
                         Some(Keyword::FROM) => "FROM",
                         Some(Keyword::IN) => "IN",
-                        _ => "", // unexpected
+                        _ => unreachable!(),
                     };
                     write!(f, " {} {db_name}", keyword)?;
                 }
@@ -4422,17 +4422,17 @@ impl fmt::Display for Statement {
                 }
                 Ok(())
             }
-            Statement::ShowViews { 
-                db_name_keyword, 
-                db_name, 
-                filter 
+            Statement::ShowViews {
+                db_name_keyword,
+                db_name,
+                filter,
             } => {
                 write!(f, "SHOW VIEWS")?;
                 if let Some(db_name) = db_name {
                     let keyword = match &db_name_keyword {
                         Some(Keyword::FROM) => "FROM",
                         Some(Keyword::IN) => "IN",
-                        _ => "", // unexpected
+                        _ => unreachable!(),
                     };
                     write!(f, " {} {db_name}", keyword)?;
                 }

tests/sqlparser_hive.rs

@@ -536,16 +536,16 @@ fn parse_use() {
 
 #[test]
 fn test_show() {
-    hive().verified_stmt("SHOW DATABASES");
-    hive().verified_stmt("SHOW DATABASES LIKE '%abc'");
-    hive().verified_stmt("SHOW SCHEMAS");
-    hive().verified_stmt("SHOW SCHEMAS LIKE '%abc'");
-    hive().verified_stmt("SHOW TABLES");
-    hive().verified_stmt("SHOW TABLES IN db1");
-    hive().verified_stmt("SHOW TABLES IN db1 'abc'");
-    hive().verified_stmt("SHOW VIEWS");
-    hive().verified_stmt("SHOW VIEWS IN db1");
-    hive().verified_stmt("SHOW VIEWS IN db1 'abc'");
+    hive_and_generic().verified_stmt("SHOW DATABASES");
+    hive_and_generic().verified_stmt("SHOW DATABASES LIKE '%abc'");
+    hive_and_generic().verified_stmt("SHOW SCHEMAS");
+    hive_and_generic().verified_stmt("SHOW SCHEMAS LIKE '%abc'");
+    hive_and_generic().verified_stmt("SHOW TABLES");
+    hive_and_generic().verified_stmt("SHOW TABLES IN db1");
+    hive_and_generic().verified_stmt("SHOW TABLES IN db1 'abc'");
+    hive_and_generic().verified_stmt("SHOW VIEWS");
+    hive_and_generic().verified_stmt("SHOW VIEWS IN db1");
+    hive_and_generic().verified_stmt("SHOW VIEWS IN db1 'abc'");
 }
 
 fn hive() -> TestedDialects {