resolve comments

Author: byte-sourcerer

src/ast/mod.rs

@@ -7766,13 +7766,15 @@ impl fmt::Display for RenameTable {
     }
 }
 
+/// table object for insertion
 #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
 pub enum TableObject {
+    // for simple table name
     TableName(#[cfg_attr(feature = "visitor", visit(with = "visit_relation"))] ObjectName),
 
-    // Clickhouse: [Table functions](https://clickhouse.com/docs/en/sql-reference/table-functions)
+    // for Clickhouse [table functions](https://clickhouse.com/docs/en/sql-reference/table-functions)
     TableFunction(Function),
 }
 

src/parser/mod.rs

@@ -8858,23 +8858,18 @@ impl<'a> Parser<'a> {
         }
     }
 
-    pub fn parse_table_object(
-        &mut self,
-        in_table_clause: bool,
-    ) -> Result<TableObject, ParserError> {
+    /// Parse a table object for insetion
+    /// e.g. `some_database.some_table` or `FUNCTION some_table_func(...)`
+    pub fn parse_table_object(&mut self) -> Result<TableObject, ParserError> {
         if dialect_of!(self is ClickHouseDialect) && self.parse_keyword(Keyword::FUNCTION) {
-            self.parse_table_function().map(TableObject::TableFunction)
+            let fn_name = self.parse_object_name(false)?;
+            self.parse_function_call(fn_name)
+                .map(TableObject::TableFunction)
         } else {
-            self.parse_object_name(in_table_clause)
-                .map(TableObject::TableName)
+            self.parse_object_name(false).map(TableObject::TableName)
         }
     }
 
-    pub fn parse_table_function(&mut self) -> Result<Function, ParserError> {
-        let fn_name = self.parse_object_name(false)?;
-        self.parse_function_call(fn_name)
-    }
-
     /// Parse a possibly qualified, possibly quoted identifier, e.g.
     /// `foo` or `myschema."table"
     ///
@@ -11905,7 +11900,7 @@ impl<'a> Parser<'a> {
         } else {
             // Hive lets you put table here regardless
             let table = self.parse_keyword(Keyword::TABLE);
-            let table_object = self.parse_table_object(false)?;
+            let table_object = self.parse_table_object()?;
 
             let table_alias =
                 if dialect_of!(self is PostgreSqlDialect) && self.parse_keyword(Keyword::AS) {

src/test_utils.rs

@@ -154,7 +154,7 @@ impl TestedDialects {
     pub fn one_statement_parses_to(&self, sql: &str, canonical: &str) -> Statement {
         let mut statements = self.parse_sql_statements(sql).expect(sql);
         assert_eq!(statements.len(), 1);
-
+        println!("sql: {}", sql);
         if !canonical.is_empty() && sql != canonical {
             assert_eq!(self.parse_sql_statements(canonical).unwrap(), statements);
         }

tests/sqlparser_clickhouse.rs

@@ -225,6 +225,7 @@ fn parse_create_table() {
 #[test]
 fn parse_insert_into_function() {
     clickhouse().verified_stmt(r#"INSERT INTO TABLE FUNCTION remote('localhost', default.simple_table) VALUES (100, 'inserted via remote()')"#);
+    clickhouse().verified_stmt(r#"INSERT INTO FUNCTION remote('localhost', default.simple_table) VALUES (100, 'inserted via remote()')"#);
 }
 
 #[test]