Extend Visitor trait for Value type #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomershaniii
force-pushed
the
Value_support_for_visitor
branch
2 times, most recently
from
bcabc4d to
e5248ef
Compare
iffyio
reviewed
Feb 20, 2025
| } | ||
| } | ||
|
|
||
| struct QuickVisitor; // [`TestVisitor`] is too slow to iterate over thousands of nodes |
There was a problem hiding this comment.
is it reasonable to reserve the overflow test case? it sounded like it was supposed to test ability to cover large number of entries
There was a problem hiding this comment.
@iffyio thanks for the feedback, indeed it was overlooked
tomershaniii
force-pushed
the
Value_support_for_visitor
branch
from
4a05b6f to
397007e
Compare
iffyio
approved these changes
Feb 21, 2025
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing the AST Visitor so it is possible to visit Values