Regarding commit c893bda, it should be noted that the MsSQL parser for triggers is incorrect, as it does not include much of their syntax, and currently always adds in a FOR STATEMENT, which is incorrect. This is clearly way outside the current PR objectives though. I have patched the parse trigger so that it would be compatible with the MsSQL tests, but I am completely unfamiliar with that dialect so I would leave a more refined extension to somebody more familiar with it.

Is there anything else needed to be done for this PR? @iffyio

@LucaCappelletti94 could you take a look at this comment?

Hi @iffyio, I replied to it here: #2037 (comment)

@LucaCappelletti94 the link takes me to the top of the page not sure why but I'm unable to find the comment in this case

@LucaCappelletti94 the link takes me to the top of the page not sure why but I'm unable to find the comment in this case

@iffyio Here follows the comment:

So, if you mean to refactor this into:

} else {
    None
};

would simply make it more permissive and allow for parsing stuff that does not make sense in some dialects.

Conversely, the following:

} else {
    self.expect_keyword_is(Keyword::FOR)?;

    None
};

would crash for valid SQLite statements.