-
Notifications
You must be signed in to change notification settings - Fork 672
Oracle: Support for MERGE predicates #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9f705bc to
f406386
Compare
|
@xitep Re this and #2103 PRs, The parser currently doesn't support oracle as a dialect, so that it would be a bit confusing going forward having code specific to the dialect but being unable to guarantee its consistency/behavior. I'm thinking we could instead start by introducing oracle as a supported dialect here? |
|
c316622 to
b0c0ae2
Compare
91eb047 to
0d25537
Compare
Co-authored-by: Ifeanyi Ubah <[email protected]>
0d25537 to
0d30912
Compare
i would have a draft of an |
Oracle supports small extensions to the standard MERGE syntax (that I'd need to support.) In particular:
... WHEN MATCHED ... UPDATE ... ***[WHERE <expr>] [DELETE WHERE <expr>]***... WHEN NOT MATCHED ... INSERT ... ***[WHERE <expr>]***Here's the documentation for reference.
Quoted column names
Additionally, Oracle also allows quoted names in
MERGE INTO a.b ... INSERT (a.b.col1, a.b.col2) ...(or event... INSERT (b.col1, b.col2) ...with the same meaning as... INSERT (col1, col2)as long asa.bdenotes the target table of the merge.For the sake of compatibility, this draft PR makes a trade-off: the parser validates that "a.b." corresponds to the target table, and strips away the prefix in order to keep
MergeInsertExpr::columnsaVec<Ident>. While preserving semantics, the implication is that such a parsed statements doesn't render back in the exact same form, though.Not doing the validation and stripping, we'd probably need to end up with a
Vec<QualifiedName>. I would be glad to hear your opinion how to move forward. Personally, I'd be fine with theVec<QualifiedName>allowing me to re-produce the statement as originally written.Note
Parser::merge_parse_clausesprivate.)Mergestruct akin toInsert,Update, ... this makes it easier to pass the merge-relevat data around in a type-safe wayMissing
Vec<ObjectName>