Extract out date time parsing to a DateTimeParser trait with chrono & jiff implementations. Overall jiff seems slightly faster in the case where parsing has no errors but slower when using multiple formats (higher cost for Error handling).

Author: Omega359

Cargo.lock

@@ -417,7 +417,7 @@ async fn query_to_timestamp() -> Result<()> {
         .collect()
         .await;
 
-    let expected = "Execution error: Error parsing timestamp from '01-14-2023 01/01/30' using format '%d-%m-%Y %H:%M:%S': input is out of range";
+    let expected = "Error parsing timestamp from '01-14-2023 01/01/30' using formats: [\"%d-%m-%Y %H:%M:%S\"]: input is out of range";
     assert_contains!(result.unwrap_err().to_string(), expected);
 
     // note that using arrays for the chrono formats is not supported

datafusion-examples/examples/builtin_functions/date_time.rs

@@ -505,11 +505,17 @@ config_namespace! {
         /// Defaults to the number of CPU cores on the system
         pub target_partitions: usize, transform = ExecutionOptions::normalized_parallelism, default = get_available_parallelism()
 
+        /// The date time parser to use when parsing date time values.
+        ///
+        /// Defaults to 'chrono'. 'jiff' is supported when the 'jiff' feature is enabled.
+        pub date_time_parser: Option<String>, default = Some("chrono".to_string())
+
         /// The default time zone
         ///
         /// Some functions, e.g. `now` return timestamps in this time zone
         pub time_zone: Option<String>, default = None
 
+
         /// Parquet options
         pub parquet: ParquetOptions, default = Default::default()
 

datafusion/common/src/config.rs

@@ -109,6 +109,7 @@ unicode_expressions = [
     "datafusion-functions/unicode_expressions",
 ]
 extended_tests = []
+jiff = ["datafusion-functions/jiff"]
 
 [dependencies]
 arrow = { workspace = true }

datafusion/core/Cargo.toml

@@ -52,6 +52,8 @@ default = [
 ]
 # enable encode/decode functions
 encoding_expressions = ["base64", "hex"]
+# enable jiff timestamp parsing
+jiff = ["dep:jiff"]
 # enable math functions
 math_expressions = []
 # enable regular expressions
@@ -78,8 +80,11 @@ datafusion-execution = { workspace = true }
 datafusion-expr = { workspace = true }
 datafusion-expr-common = { workspace = true }
 datafusion-macros = { workspace = true }
+dyn-eq = "0.1.3"
+dyn-hash = "1.0.0"
 hex = { workspace = true, optional = true }
 itertools = { workspace = true }
+jiff = { version = "0.2.16", optional = true }
 log = { workspace = true }
 md-5 = { version = "^0.10.0", optional = true }
 num-traits = { workspace = true }
@@ -115,7 +120,7 @@ required-features = ["string_expressions"]
 [[bench]]
 harness = false
 name = "to_timestamp"
-required-features = ["datetime_expressions"]
+required-features = ["datetime_expressions", "jiff"]
 
 [[bench]]
 harness = false