Refactor duplicate code in type_coercion/functions.rs (#19518)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

- Initial work before tackling #19004

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

Found lots of code duplicated here, so unifying them.

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

Introduce new trait `UDFCoercionExt` to unify functions across
scalar/aggregate/window UDFs for use in a single generic implementation.
New unified functions `fields_with_udf` and `get_valid_types_with_udf`
which are generic across this new trait.

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

Existing tests.

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

Yes, deprecating functions.

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

---------

Co-authored-by: Oleks V <[email protected]>

Author: Jefffrey

datafusion/core/tests/fuzz_cases/window_fuzz.rs

@@ -35,7 +35,7 @@ use datafusion::prelude::{SessionConfig, SessionContext};
 use datafusion_common::HashMap;
 use datafusion_common::{Result, ScalarValue};
 use datafusion_common_runtime::SpawnedTask;
-use datafusion_expr::type_coercion::functions::fields_with_aggregate_udf;
+use datafusion_expr::type_coercion::functions::fields_with_udf;
 use datafusion_expr::{
     WindowFrame, WindowFrameBound, WindowFrameUnits, WindowFunctionDefinition,
 };
@@ -451,7 +451,7 @@ fn get_random_function(
         // Do type coercion first argument
         let a = args[0].clone();
         let dt = a.return_field(schema.as_ref()).unwrap();
-        let coerced = fields_with_aggregate_udf(&[dt], udf).unwrap();
+        let coerced = fields_with_udf(&[dt], udf.as_ref()).unwrap();
         args[0] = cast(a, schema, coerced[0].data_type().clone()).unwrap();
     }
 

datafusion/expr/src/expr_schema.rs

@@ -21,13 +21,11 @@ use crate::expr::{
     InSubquery, Placeholder, ScalarFunction, TryCast, Unnest, WindowFunction,
     WindowFunctionParams,
 };
-use crate::type_coercion::functions::{
-    data_types_with_scalar_udf, fields_with_aggregate_udf, fields_with_window_udf,
-};
+use crate::type_coercion::functions::fields_with_udf;
 use crate::udf::ReturnFieldArgs;
 use crate::{LogicalPlan, Projection, Subquery, WindowFunctionDefinition, utils};
 use arrow::compute::can_cast_types;
-use arrow::datatypes::{DataType, Field, FieldRef};
+use arrow::datatypes::{DataType, Field};
 use datafusion_common::datatype::FieldExt;
 use datafusion_common::metadata::FieldMetadata;
 use datafusion_common::{
@@ -169,7 +167,7 @@ impl ExprSchemable for Expr {
                     .iter()
                     .map(|e| e.to_field(schema).map(|(_, f)| f))
                     .collect::<Result<Vec<_>>>()?;
-                let new_fields = fields_with_aggregate_udf(&fields, func)
+                let new_fields = fields_with_udf(&fields, func.as_ref())
                     .map_err(|err| {
                         let data_types = fields
                             .iter()
@@ -554,7 +552,7 @@ impl ExprSchemable for Expr {
                     .map(|e| e.to_field(schema).map(|(_, f)| f))
                     .collect::<Result<Vec<_>>>()?;
                 // Verify that function is invoked with correct number and type of arguments as defined in `TypeSignature`
-                let new_fields = fields_with_aggregate_udf(&fields, func)
+                let new_fields = fields_with_udf(&fields, func.as_ref())
                     .map_err(|err| {
                         let arg_types = fields
                             .iter()
@@ -588,8 +586,8 @@ impl ExprSchemable for Expr {
                     .map(|f| (f.data_type().clone(), f))
                     .unzip();
                 // Verify that function is invoked with correct number and type of arguments as defined in `TypeSignature`
-                let new_data_types = data_types_with_scalar_udf(&arg_types, func)
-                    .map_err(|err| {
+                let new_fields =
+                    fields_with_udf(&fields, func.as_ref()).map_err(|err| {
                         plan_datafusion_err!(
                             "{} {}",
                             match err {
@@ -603,11 +601,6 @@ impl ExprSchemable for Expr {
                             )
                         )
                     })?;
-                let new_fields = fields
-                    .into_iter()
-                    .zip(new_data_types)
-                    .map(|(f, d)| f.retyped(d))
-                    .collect::<Vec<FieldRef>>();
 
                 let arguments = args
                     .iter()
@@ -727,7 +720,7 @@ impl Expr {
                     .map(|f| f.data_type())
                     .cloned()
                     .collect::<Vec<_>>();
-                let new_fields = fields_with_aggregate_udf(&fields, udaf)
+                let new_fields = fields_with_udf(&fields, udaf.as_ref())
                     .map_err(|err| {
                         plan_datafusion_err!(
                             "{} {}",
@@ -755,7 +748,7 @@ impl Expr {
                     .map(|f| f.data_type())
                     .cloned()
                     .collect::<Vec<_>>();
-                let new_fields = fields_with_window_udf(&fields, udwf)
+                let new_fields = fields_with_udf(&fields, udwf.as_ref())
                     .map_err(|err| {
                         plan_datafusion_err!(
                             "{} {}",
@@ -828,6 +821,7 @@ mod tests {
     use super::*;
     use crate::{and, col, lit, not, or, out_ref_col_with_metadata, when};
 
+    use arrow::datatypes::FieldRef;
     use datafusion_common::{DFSchema, ScalarValue, assert_or_internal_err};
 
     macro_rules! test_is_expr_nullable {