Commit 102caeb
authored
minor: More comments to
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
`ParquetOpener::open()` is a critical function for parquet planning,
it's the entry point for many major steps like row-group/file pruning.
It has almost 400 lines of code now, this PR adds some markers to the
code blocks/important steps, to make this function easier to navigate.
(though I may have overlooked some critical steps)
Ideally, we should break these blocks into utilities. I tried extracting
some of them with AI, but the resulting utilities still have unclear
semantics, with many input arguments and output items. Overall, the
complexity doesn’t seem reduced after the change. I think it’s possible
to factor them into helper functions with clear semantics, but that
likely requires someone who understands the implementation details very
well.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->ParquetOpener::open() (#19677)1 parent 646213e commit 102caeb
1 file changed
+39
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
183 | 186 | | |
184 | 187 | | |
185 | 188 | | |
| |||
280 | 283 | | |
281 | 284 | | |
282 | 285 | | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
283 | 290 | | |
284 | 291 | | |
285 | 292 | | |
| |||
328 | 335 | | |
329 | 336 | | |
330 | 337 | | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
331 | 342 | | |
332 | 343 | | |
333 | 344 | | |
| |||
428 | 439 | | |
429 | 440 | | |
430 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
431 | 446 | | |
432 | 447 | | |
433 | 448 | | |
434 | 449 | | |
435 | 450 | | |
436 | | - | |
437 | | - | |
438 | | - | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
439 | 457 | | |
440 | 458 | | |
441 | 459 | | |
| |||
464 | 482 | | |
465 | 483 | | |
466 | 484 | | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
467 | 489 | | |
468 | 490 | | |
469 | 491 | | |
| |||
525 | 547 | | |
526 | 548 | | |
527 | 549 | | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
528 | 553 | | |
529 | 554 | | |
530 | 555 | | |
| 556 | + | |
531 | 557 | | |
532 | 558 | | |
533 | 559 | | |
| |||
545 | 571 | | |
546 | 572 | | |
547 | 573 | | |
548 | | - | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
549 | 578 | | |
550 | 579 | | |
551 | 580 | | |
| |||
564 | 593 | | |
565 | 594 | | |
566 | 595 | | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
567 | 599 | | |
568 | 600 | | |
569 | 601 | | |
| |||
621 | 653 | | |
622 | 654 | | |
623 | 655 | | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
624 | 659 | | |
625 | 660 | | |
626 | 661 | | |
| |||
0 commit comments