fix: return NULL if any of the param to make_date is NULL (#16759)

* fix: return NULL if any of the param to make_date is NULL

* fmt

---------

Co-authored-by: Andrew Lamb <[email protected]>

Author: feniljain

datafusion/functions/src/datetime/make_date.rs

@@ -122,6 +122,13 @@ impl ScalarUDFImpl for MakeDateFunc {
 
         let [years, months, days] = take_function_args(self.name(), args)?;
 
+        if matches!(years, ColumnarValue::Scalar(ScalarValue::Null))
+            || matches!(months, ColumnarValue::Scalar(ScalarValue::Null))
+            || matches!(days, ColumnarValue::Scalar(ScalarValue::Null))
+        {
+            return Ok(ColumnarValue::Scalar(ScalarValue::Null));
+        }
+
         let years = years.cast_to(&Int32, None)?;
         let months = months.cast_to(&Int32, None)?;
         let days = days.cast_to(&Int32, None)?;
@@ -377,4 +384,19 @@ mod tests {
             "Arrow error: Cast error: Can't cast value 4294967295 to type Int32"
         );
     }
+
+    #[test]
+    fn test_make_date_null_param() {
+        let res = invoke_make_date_with_args(
+            vec![
+                ColumnarValue::Scalar(ScalarValue::Null),
+                ColumnarValue::Scalar(ScalarValue::Int64(Some(1))),
+                ColumnarValue::Scalar(ScalarValue::UInt32(Some(14))),
+            ],
+            1,
+        )
+        .expect("that make_date parsed values without error");
+
+        assert!(matches!(res, ColumnarValue::Scalar(ScalarValue::Null)));
+    }
 }