Commit 3a0ca4e
authored
## Which issue does this PR close?
- Part of #19656
## Rationale for this change
rust_decimal is a one person crate and is released somewhat infrequently
* https://github.com/paupino/rust-decimal
* https://crates.io/crates/rust_decimal
It also uses a non trivial number of dependencies, including
https://crates.io/crates/rkyv, some sort of zero copy deserialization
framework that was recently subject to a RUSTSEC security advisory, see
#19656 /
#19657
Since `rust_decimal` is only used for sqllogictests to parse the results
from postgres, we can pretty easily remove the dependency on
`rust_decimal` and inline the very small amount functionality we need
for sqllogictests
This will both decrease the build time and our dependency trail.
## What changes are included in this PR?
Removes the `rust_decimal` dependency from DataFusion
and inlines the smallest required subset of decimal functionality we
need for
sqllogictests (which turns out to be pretty small)
## Are these changes tested?
Yes by CI
## Are there any user-facing changes?
No, this is all internal testing infrastructure
1 parent 566bcde commit 3a0ca4e
File tree
6 files changed
+139
-364
lines changed- .github/workflows
- datafusion/sqllogictest
- src/engines
- postgres_engine
6 files changed
+139
-364
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
0 commit comments