Skip to content

Commit 47ddd50

Browse files
authored
Add link to arrow-rs ticket in comments (#19479)
## Which issue does this PR close? - Follow on to #19441 ## Rationale for this change In #19441 @Jefffrey filed a follow on ticket for arrow-rs apache/arrow-rs#9034 I wanted to leave the context of where it could be used in DataFusion so we remember to use it when available ## What changes are included in this PR? Add a comment with a reference to apache/arrow-rs#9034 ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? No, only comments
1 parent 67b526a commit 47ddd50

File tree

1 file changed

+2
-0
lines changed
  • datafusion/common/src/scalar

1 file changed

+2
-0
lines changed

datafusion/common/src/scalar/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2989,6 +2989,8 @@ impl ScalarValue {
29892989
Some(value) => {
29902990
let mut builder =
29912991
StringViewBuilder::with_capacity(size).with_deduplicate_strings();
2992+
// Replace with upstream arrow-rs code when available:
2993+
// https://github.com/apache/arrow-rs/issues/9034
29922994
for _ in 0..size {
29932995
builder.append_value(value);
29942996
}

0 commit comments

Comments
 (0)