Skip to content

Commit 47fd638

Browse files
authored
Consolidate core_integration/datasource and rename parquet_source --> parquet_integration (#18226)
## Which issue does this PR close? - related to #11210 ## Rationale for this change Running the following command ```shell cargo test --test csv_schema_fix_test ``` Results in a 201 mb binary (and requires linking, etc) for only a few tests ```shell du -s -h target/debug/deps/csv_schema_fix_test-48507d40c6598e82 201M target/debug/deps/csv_schema_fix_test-48507d40c6598e82 ``` Let's combine that into the existing core integration test to save CI runner space and time Also, I have been confused why the parquet integration tests are named `parquet_source` (I think it is meant to mirror `ParquetSource` which is confusing) so let's change that to something more discoverable ## What changes are included in this PR? 1. Consolidate core_integration/datasource 2. rename `parquet_source` --> `parquet_integration` ## Are these changes tested? It is only tests. You can run the tests in the new location via ```shell cargo test --test core_integration -- csv ``` ## Are there any user-facing changes? No, this is all internal test rearrangement
1 parent 774b6fe commit 47fd638

File tree

4 files changed

+26
-0
lines changed

4 files changed

+26
-0
lines changed

datafusion/core/tests/core_integration.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ mod sql;
2121
/// Run all tests that are found in the `dataframe` directory
2222
mod dataframe;
2323

24+
/// Run all tests that are found in the `datasource` directory
25+
mod datasource;
26+
2427
/// Run all tests that are found in the `macro_hygiene` directory
2528
mod macro_hygiene;
2629

File renamed without changes.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
// Licensed to the Apache Software Foundation (ASF) under one
2+
// or more contributor license agreements. See the NOTICE file
3+
// distributed with this work for additional information
4+
// regarding copyright ownership. The ASF licenses this file
5+
// to you under the Apache License, Version 2.0 (the
6+
// "License"); you may not use this file except in compliance
7+
// with the License. You may obtain a copy of the License at
8+
//
9+
// http://www.apache.org/licenses/LICENSE-2.0
10+
//
11+
// Unless required by applicable law or agreed to in writing,
12+
// software distributed under the License is distributed on an
13+
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
// KIND, either express or implied. See the License for the
15+
// specific language governing permissions and limitations
16+
// under the License.
17+
18+
//! Tests for various DataSources
19+
//!
20+
//! Note tests for the Parquet format are in `parquet_integration` binary
21+
22+
// Include tests in csv module
23+
mod csv;
File renamed without changes.

0 commit comments

Comments
 (0)