Skip to content

Commit 48f5d0b

Browse files
authored
fix: Fix skip aggregate test to cover regression (#19461)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change There is a FIXME label in the sqllogictest for the aggregation test in the file https://github.com/apache/datafusion/blob/2e3707e380172a4ba1ae5efabe7bd27a354bfb2d/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt#L178 Since the issue related to this comment has been merged, we should fix the test. I have contacted @2010YOUY01 for approval before opening the PR. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? - Updated the `aggregate_skip_partial` slt test to cover the case <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent bb9a4a7 commit 48f5d0b

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

datafusion/sqllogictest/test_files/aggregate_skip_partial.slt

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -175,18 +175,17 @@ GROUP BY 1, 2 ORDER BY 1 LIMIT 5;
175175
-2117946883 d 1 0 0 0
176176
-2098805236 c 1 0 0 0
177177

178-
# FIXME: add bool_and(v3) column when issue fixed
179-
# ISSUE https://github.com/apache/datafusion/issues/11846
180-
query TBBB rowsort
181-
select v1, bool_or(v2), bool_and(v2), bool_or(v3)
178+
# Regression test for https://github.com/apache/datafusion/issues/11846
179+
query TBBBB rowsort
180+
select v1, bool_or(v2), bool_and(v2), bool_or(v3), bool_and(v3)
182181
from aggregate_test_100_bool
183182
group by v1
184183
----
185-
a true false true
186-
b true false true
187-
c true false false
188-
d true false false
189-
e true false NULL
184+
a true false true true
185+
b true false true true
186+
c true false false false
187+
d true false false false
188+
e true false NULL NULL
190189

191190
query TBBB rowsort
192191
select v1,

0 commit comments

Comments
 (0)