Skip to content

Commit 4e877a0

Browse files
authored
refactor: make structs public and implement Default trait (#14030)
1 parent b2f8e94 commit 4e877a0

File tree

18 files changed

+125
-17
lines changed

18 files changed

+125
-17
lines changed

datafusion/functions-nested/src/cardinality.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,16 @@ impl Cardinality {
7575
)
7676
)]
7777
#[derive(Debug)]
78-
pub(super) struct Cardinality {
78+
pub struct Cardinality {
7979
signature: Signature,
8080
aliases: Vec<String>,
8181
}
82+
83+
impl Default for Cardinality {
84+
fn default() -> Self {
85+
Self::new()
86+
}
87+
}
8288
impl ScalarUDFImpl for Cardinality {
8389
fn as_any(&self) -> &dyn Any {
8490
self

datafusion/functions-nested/src/dimension.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,17 @@ make_udf_expr_and_func!(
6161
)
6262
)]
6363
#[derive(Debug)]
64-
pub(super) struct ArrayDims {
64+
pub struct ArrayDims {
6565
signature: Signature,
6666
aliases: Vec<String>,
6767
}
6868

69+
impl Default for ArrayDims {
70+
fn default() -> Self {
71+
Self::new()
72+
}
73+
}
74+
6975
impl ArrayDims {
7076
pub fn new() -> Self {
7177
Self {

datafusion/functions-nested/src/distance.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,17 @@ make_udf_expr_and_func!(
6767
)
6868
)]
6969
#[derive(Debug)]
70-
pub(super) struct ArrayDistance {
70+
pub struct ArrayDistance {
7171
signature: Signature,
7272
aliases: Vec<String>,
7373
}
7474

75+
impl Default for ArrayDistance {
76+
fn default() -> Self {
77+
Self::new()
78+
}
79+
}
80+
7581
impl ArrayDistance {
7682
pub fn new() -> Self {
7783
Self {

datafusion/functions-nested/src/empty.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,16 @@ make_udf_expr_and_func!(
5656
)
5757
)]
5858
#[derive(Debug)]
59-
pub(super) struct ArrayEmpty {
59+
pub struct ArrayEmpty {
6060
signature: Signature,
6161
aliases: Vec<String>,
6262
}
63+
64+
impl Default for ArrayEmpty {
65+
fn default() -> Self {
66+
Self::new()
67+
}
68+
}
6369
impl ArrayEmpty {
6470
pub fn new() -> Self {
6571
Self {

datafusion/functions-nested/src/except.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,17 @@ make_udf_expr_and_func!(
6767
)
6868
)]
6969
#[derive(Debug)]
70-
pub(super) struct ArrayExcept {
70+
pub struct ArrayExcept {
7171
signature: Signature,
7272
aliases: Vec<String>,
7373
}
7474

75+
impl Default for ArrayExcept {
76+
fn default() -> Self {
77+
Self::new()
78+
}
79+
}
80+
7581
impl ArrayExcept {
7682
pub fn new() -> Self {
7783
Self {

datafusion/functions-nested/src/extract.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,17 @@ make_udf_expr_and_func!(
102102
)
103103
)]
104104
#[derive(Debug)]
105-
pub(super) struct ArrayElement {
105+
pub struct ArrayElement {
106106
signature: Signature,
107107
aliases: Vec<String>,
108108
}
109109

110+
impl Default for ArrayElement {
111+
fn default() -> Self {
112+
Self::new()
113+
}
114+
}
115+
110116
impl ArrayElement {
111117
pub fn new() -> Self {
112118
Self {

datafusion/functions-nested/src/map_extract.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,17 @@ SELECT map_extract(MAP {'x': 10, 'y': NULL, 'z': 30}, 'y');
7272
)
7373
)]
7474
#[derive(Debug)]
75-
pub(super) struct MapExtract {
75+
pub struct MapExtract {
7676
signature: Signature,
7777
aliases: Vec<String>,
7878
}
7979

80+
impl Default for MapExtract {
81+
fn default() -> Self {
82+
Self::new()
83+
}
84+
}
85+
8086
impl MapExtract {
8187
pub fn new() -> Self {
8288
Self {

datafusion/functions-nested/src/map_keys.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,16 @@ SELECT map_keys(map([100, 5], [42, 43]));
5656
)
5757
)]
5858
#[derive(Debug)]
59-
pub(crate) struct MapKeysFunc {
59+
pub struct MapKeysFunc {
6060
signature: Signature,
6161
}
6262

63+
impl Default for MapKeysFunc {
64+
fn default() -> Self {
65+
Self::new()
66+
}
67+
}
68+
6369
impl MapKeysFunc {
6470
pub fn new() -> Self {
6571
Self {

datafusion/functions-nested/src/map_values.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,12 @@ pub(crate) struct MapValuesFunc {
6060
signature: Signature,
6161
}
6262

63+
impl Default for MapValuesFunc {
64+
fn default() -> Self {
65+
Self::new()
66+
}
67+
}
68+
6369
impl MapValuesFunc {
6470
pub fn new() -> Self {
6571
Self {

datafusion/functions-nested/src/position.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,16 @@ make_udf_expr_and_func!(
7676
argument(name = "index", description = "Index at which to start searching.")
7777
)]
7878
#[derive(Debug)]
79-
pub(super) struct ArrayPosition {
79+
pub struct ArrayPosition {
8080
signature: Signature,
8181
aliases: Vec<String>,
8282
}
83+
84+
impl Default for ArrayPosition {
85+
fn default() -> Self {
86+
Self::new()
87+
}
88+
}
8389
impl ArrayPosition {
8490
pub fn new() -> Self {
8591
Self {

0 commit comments

Comments
 (0)