Skip to content

Commit 653caa1

Browse files
2010YOUY01Jefffreymartin-g
authored
doc: add FilterExec metrics to user-guide/metrics.md (#19043)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> part of #16602 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Start adding each operator's metrics to the user-guide page ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Jeffrey Vo <[email protected]> Co-authored-by: Martin Grigorov <[email protected]>
1 parent a1bb74b commit 653caa1

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

datafusion/physical-plan/src/filter.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,10 +686,12 @@ struct FilterExecStream {
686686

687687
/// The metrics for `FilterExec`
688688
struct FilterExecMetrics {
689-
// Common metrics for most operators
689+
/// Common metrics for most operators
690690
baseline_metrics: BaselineMetrics,
691-
// Selectivity of the filter, calculated as output_rows / input_rows
691+
/// Selectivity of the filter, calculated as output_rows / input_rows
692692
selectivity: RatioMetrics,
693+
// Remember to update `docs/source/user-guide/metrics.md` when adding new metrics,
694+
// or modifying metrics comments
693695
}
694696

695697
impl FilterExecMetrics {

docs/source/user-guide/metrics.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,12 @@ DataFusion operators expose runtime metrics so you can understand where time is
3636

3737
## Operator-specific Metrics
3838

39-
TODO
39+
### FilterExec
40+
41+
| Metric | Description |
42+
| ----------- | ----------------------------------------------------------------- |
43+
| selectivity | Selectivity of the filter, calculated as output_rows / input_rows |
44+
45+
## TODO
46+
47+
Add metrics for the remaining operators

0 commit comments

Comments
 (0)