@@ -732,12 +732,16 @@ config_namespace! {
732732 pub max_predicate_cache_size: Option <usize >, default = None
733733
734734 /// (reading) Minimum filter effectiveness threshold for adaptive filter
735- /// pushdown. When `pushdown_filters` is enabled, filters that don't filter
736- /// out at least this fraction of rows will be demoted from row-level filters
737- /// to post-scan filters. This helps avoid the I/O cost of late materialization
738- /// for filters that aren't selective enough. Valid values are 0.0 to 1.0, where
739- /// 0.8 means filters must filter out at least 80% of rows to remain as row filters.
740- pub filter_effectiveness_threshold: f64 , default = 0.8
735+ /// pushdown.
736+ /// Only filters that filter out at least this fraction of rows will be
737+ /// promoted to row filters during adaptive filter pushdown.
738+ /// A value of 1.0 means only filters that filter out all rows will be
739+ /// promoted. A value of 0.0 means all filters will be promoted.
740+ /// Because there can be a high I/O cost to pushing down ineffective filters,
741+ /// recommended values are in the range [0.8, 0.95], depending on random I/0 costs.
742+ ///
743+ /// (disable for now to debug tpch performance, 1.0 means no adaptive pushdown)
744+ pub filter_effectiveness_threshold: f64 , default = 1.0
741745
742746 // The following options affect writing to parquet files
743747 // and map to parquet::file::properties::WriterProperties
0 commit comments