Skip to content

Commit 955fd41

Browse files
SolariSystemsSolari Systems
andauthored
docs: fix typos in PartitionEvaluator trait documentation (#19631)
## Which issue does this PR close? Closes #11700 ## Rationale for this change The documentation for the `PartitionEvaluator` trait contains two typos that could confuse readers. ## What changes are included in this PR? 1. **Line 178**: Removed extraneous 'x' character from the `evaluate` method documentation - Changed `partition.x` to `partition.` 2. **Line 213**: Corrected the RANK example to show proper SQL RANK behavior - Ties should have the same rank value, not sequential values - Changed `D | 5` to `D | 4` ## Are these changes tested? Documentation-only change - no code affected. ## Are there any user-facing changes? No, documentation only. Co-authored-by: Solari Systems <[email protected]>
1 parent 7fde30a commit 955fd41

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

datafusion/expr/src/partition_evaluator.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ pub trait PartitionEvaluator: Debug + Send {
175175
}
176176

177177
/// Evaluate window function on a range of rows in an input
178-
/// partition.x
178+
/// partition.
179179
///
180180
/// This is the simplest and most general function to implement
181181
/// but also the least performant as it creates output one row at
@@ -210,7 +210,7 @@ pub trait PartitionEvaluator: Debug + Send {
210210
/// A | 1
211211
/// C | 3
212212
/// D | 4
213-
/// D | 5
213+
/// D | 4
214214
/// ```
215215
///
216216
/// For this case, `num_rows` would be `5` and the

0 commit comments

Comments
 (0)