Un-deprecate with_default_selectivity per reviewer feedback

The reviewer pointed out that with_default_selectivity() simply updates a field
and doesn't need the overhead of creating a new FilterExec via the builder.
Restored the original efficient implementation.

Only with_projection() and with_batch_size() remain deprecated, as they
benefit from the builder pattern's single property computation.

- Restored original with_default_selectivity implementation
- Updated upgrading.md to reflect only 2 deprecated methods
- All 114 filter tests passing
- No clippy warnings

Author: GaneshPatil7517

datafusion/physical-plan/src/filter.rs

@@ -195,20 +195,17 @@ impl FilterExec {
     }
 
     /// Set the default selectivity
-    ///
-    /// # Deprecated
-    /// Use [`FilterExecBuilder::with_default_selectivity`] instead
-    #[deprecated(since = "52.0.0", note = "Use FilterExecBuilder::with_default_selectivity instead")]
     pub fn with_default_selectivity(
-        self,
+        mut self,
         default_selectivity: u8,
     ) -> Result<Self, DataFusionError> {
-        FilterExecBuilder::new(Arc::clone(&self.predicate), Arc::clone(&self.input))
-            .with_projection(self.projection.clone())
-            .with_default_selectivity(default_selectivity)
-            .with_batch_size(self.batch_size)
-            .with_fetch(self.fetch)
-            .build()
+        if default_selectivity > 100 {
+            return plan_err!(
+                "Default filter selectivity value needs to be less than or equal to 100"
+            );
+        }
+        self.default_selectivity = default_selectivity;
+        Ok(self)
     }
 
     /// Return new instance of [FilterExec] with the given projection.

docs/source/library-user-guide/upgrading.md

@@ -30,7 +30,6 @@ You can see the current [status of the `52.0.0`release here](https://github.com/
 The following methods on `FilterExec` have been deprecated in favor of using `FilterExecBuilder`:
 
 - `with_projection()`
-- `with_default_selectivity()`
 - `with_batch_size()`
 
 **Who is affected:**
@@ -46,20 +45,22 @@ Use `FilterExecBuilder` instead of chaining method calls on `FilterExec`:
 ```rust,ignore
 let filter = FilterExec::try_new(predicate, input)?
     .with_projection(Some(vec![0, 2]))?
-    .with_default_selectivity(30)?;
+    .with_batch_size(8192)?;
 ```
 
 **After:**
 
 ```rust,ignore
 let filter = FilterExecBuilder::new(predicate, input)
     .with_projection(Some(vec![0, 2]))
-    .with_default_selectivity(30)
+    .with_batch_size(8192)
     .build()?;
 ```
 
 The builder pattern is more efficient as it computes properties once during `build()` rather than recomputing them for each method call.
 
+Note: `with_default_selectivity()` is not deprecated as it simply updates a field value and does not require the overhead of the builder pattern.
+
 ### Changes to DFSchema API
 
 To permit more efficient planning, several methods on `DFSchema` have been