Skip to content

Commit c173de1

Browse files
authored
fix: expose ListFilesEntry (#19804)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - This is a follow-up of #19573 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> `ListFilesEntry` is part of the public `ListFilesCache` trait signature, but it was defined inside the private list_files_cache module and was not re-exported from `cache/mod.rs`. As a result, downstream crates could not name the return type of `ListFilesCache::list_entries`, making the public trait effectively unusable. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Re-export ListFilesEntry from `datafusion_execution::cache` ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Existing tests. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> Fix the broken public API.
1 parent a414ea0 commit c173de1

File tree

1 file changed

+1
-0
lines changed
  • datafusion/execution/src/cache

1 file changed

+1
-0
lines changed

datafusion/execution/src/cache/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ mod list_files_cache;
2424

2525
pub use file_metadata_cache::DefaultFilesMetadataCache;
2626
pub use list_files_cache::DefaultListFilesCache;
27+
pub use list_files_cache::ListFilesEntry;
2728
pub use list_files_cache::TableScopedPath;
2829

2930
/// Base trait for cache implementations with common operations.

0 commit comments

Comments
 (0)