Skip to content

Commit c63ca33

Browse files
fix: increase ROUND decimal precision to prevent overflow truncation (#19926)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #19921. ## Rationale for this change `SELECT ROUND('999.9'::DECIMAL(4,1))` incorrectly returned `100.0` instead of `1000`. When rounding a decimal value causes a carry-over that increases the number of digits (e.g., 999.9 → 1000.0), the result overflows the original precision constraint. The overflow was silently truncated during display, producing incorrect results. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? - Fixes ROUND on DECIMAL so carry-over doesn’t silently truncate/produce wrong results. - When decimal_places is a constant (including omitted/NULL), ROUND now reduces the output scale to min(input_scale, max(decimal_places, 0)) (Spark/DuckDB-style), reclaiming precision for the integer part. - When decimal_places is not a constant (e.g. a column/array), ROUND keeps the original scale and may increase precision by 1 (capped); if precision is already max and the rounded value can’t fit, it returns an overflow error instead of a wrong value. - Adds/updates sqllogictests for these behaviors and edge cases. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? - Added new sqllogictest case for the specific bug scenario - Updated 2 existing tests with new expected precision values - All existing tests pass <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? | Aspect | Before | After | | --- | --- | --- | | ROUND('999.9'::DECIMAL(4,1)) | 100.0 (wrong) | 1000 (correct) | | Return type (default/literal dp) | Decimal128(4, 1) | Decimal128(4, 0) | - Return type for DECIMAL inputs can change: with literal dp it generally reduces scale; with non-literal dp it keeps scale and may increase precision by 1. - New error case: when precision is already max and dp is non-literal, ROUND may now error on overflow rather than return a truncated/wrong decimal. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
1 parent e583fe9 commit c63ca33

File tree

3 files changed

+477
-65
lines changed

3 files changed

+477
-65
lines changed

0 commit comments

Comments
 (0)