Fix cargo doc test

Author: LiaCastaneda

datafusion/functions-aggregate-common/src/aggregate/count_distinct/native.rs

@@ -162,7 +162,7 @@ impl<T: ArrowPrimitiveType + Debug> Accumulator for FloatDistinctCountAccumulato
         Ok(ScalarValue::Int64(Some(self.values.values.len() as i64)))
     }
 
-    fn size(&self, pool: Option<&dyn MemoryPool>) -> usize {
-        size_of_val(self) + self.values.size(pool)
+    fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
+        size_of_val(self) + self.values.size()
     }
 }

datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/accumulate.rs

@@ -23,7 +23,6 @@ use arrow::array::{Array, BooleanArray, BooleanBufferBuilder, PrimitiveArray};
 use arrow::buffer::{BooleanBuffer, NullBuffer};
 use arrow::datatypes::ArrowPrimitiveType;
 
-use arrow_buffer::MemoryPool;
 use datafusion_expr_common::groups_accumulator::EmitTo;
 /// Track the accumulator null state per row: if any values for that
 /// group were null and if any values have been seen at all for that group.
@@ -76,7 +75,7 @@ impl NullState {
     }
 
     /// return the size of all buffers allocated by this null state, not including self
-    pub fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
+    pub fn size(&self) -> usize {
         // capacity is in bits, so convert to bytes
         self.seen_values.capacity() / 8
     }

datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/bool_op.rs

@@ -140,9 +140,9 @@ where
         self.update_batch(values, group_indices, opt_filter, total_num_groups)
     }
 
-    fn size(&self, pool: Option<&dyn MemoryPool>) -> usize {
+    fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
         // capacity is in bits, so convert to bytes
-        self.values.capacity() / 8 + self.null_state.size(pool)
+        self.values.capacity() / 8 + self.null_state.size()
     }
 
     fn convert_to_state(

datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/prim_op.rs

@@ -195,7 +195,7 @@ where
         true
     }
 
-    fn size(&self, pool: Option<&dyn MemoryPool>) -> usize {
-        self.values.capacity() * size_of::<T::Native>() + self.null_state.size(pool)
+    fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
+        self.values.capacity() * size_of::<T::Native>() + self.null_state.size()
     }
 }

datafusion/functions-aggregate-common/src/aggregate/sum_distinct/numeric.rs

@@ -78,7 +78,7 @@ impl<T: ArrowPrimitiveType + Debug> Accumulator for DistinctSumAccumulator<T> {
         }
     }
 
-    fn size(&self, pool: Option<&dyn MemoryPool>) -> usize {
-        size_of_val(self) + self.values.size(pool)
+    fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
+        size_of_val(self) + self.values.size()
     }
 }

datafusion/functions-aggregate-common/src/utils.rs

@@ -23,7 +23,6 @@ use arrow::compute::SortOptions;
 use arrow::datatypes::{
     ArrowNativeType, DataType, DecimalType, Field, FieldRef, ToByteSlice,
 };
-use arrow_buffer::MemoryPool;
 use datafusion_common::cast::{as_list_array, as_primitive_array};
 use datafusion_common::utils::SingleRowListArrayBuilder;
 use datafusion_common::utils::memory::estimate_memory_size;
@@ -259,7 +258,7 @@ impl<T: ArrowPrimitiveType> GenericDistinctBuffer<T> {
     }
 
     /// Mirrors [`Accumulator::size`].
-    pub fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
+    pub fn size(&self) -> usize {
         let num_elements = self.values.len();
         let fixed_size = size_of_val(self) + size_of_val(&self.values);
         estimate_memory_size::<T::Native>(num_elements, fixed_size).unwrap()

datafusion/functions-aggregate/src/array_agg.rs

@@ -801,6 +801,7 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
             }
         }
 
+        // Add size of the `self.ordering_values`
         total += size_of::<Vec<ScalarValue>>() * self.ordering_values.capacity();
         for row in &self.ordering_values {
             total += size_of_val(row) + (size_of::<ScalarValue>() * row.capacity());
@@ -819,12 +820,15 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
             }
         }
 
+        // Add size of the `self.datatypes`
         total += size_of::<DataType>() * self.datatypes.capacity();
         for dtype in &self.datatypes {
             total += dtype.size() - size_of_val(dtype);
         }
 
+        // Add size of the `self.ordering_req`
         total += size_of::<PhysicalSortExpr>() * self.ordering_req.capacity();
+        // TODO: Calculate size of each `PhysicalSortExpr` more accurately.
         total
     }
 }

datafusion/functions-aggregate/src/median.rs

@@ -575,8 +575,8 @@ impl<T: ArrowNumericType + Debug> Accumulator for DistinctMedianAccumulator<T> {
         ScalarValue::new_primitive::<T>(median, &self.data_type)
     }
 
-    fn size(&self, pool: Option<&dyn MemoryPool>) -> usize {
-        size_of_val(self) + self.distinct_values.size(pool)
+    fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
+        size_of_val(self) + self.distinct_values.size()
     }
 }
 

datafusion/functions-aggregate/src/percentile_cont.rs

@@ -777,8 +777,8 @@ impl<T: ArrowNumericType + Debug> Accumulator for DistinctPercentileContAccumula
         ScalarValue::new_primitive::<T>(value, &self.data_type)
     }
 
-    fn size(&self, pool: Option<&dyn MemoryPool>) -> usize {
-        size_of_val(self) + self.distinct_values.size(pool)
+    fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
+        size_of_val(self) + self.distinct_values.size()
     }
 }
 

datafusion/functions-aggregate/src/utils.rs

@@ -24,6 +24,7 @@ use datafusion_expr::ColumnarValue;
 use datafusion_physical_expr_common::physical_expr::PhysicalExpr;
 
 /// Recursively claims all buffers in an ArrayData and its children with the memory pool.
+/// TODO: remove once https://github.com/apache/arrow-rs/pull/8918 lands.
 pub(crate) fn claim_buffers_recursive(
     data: &arrow::array::ArrayData,
     pool: &dyn arrow_buffer::MemoryPool,