wip

Author: Dandandan

datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/accumulate.rs

@@ -110,10 +110,7 @@ impl NullState {
         T: ArrowPrimitiveType + Send,
         F: FnMut(usize, T::Native) + Send,
     {
-        if self.seen_values.capacity() == 0
-            && opt_filter.is_none()
-            && values.null_count() == 0
-        {
+        if self.all_seen() == 0 && opt_filter.is_none() && values.null_count() == 0 {
             accumulate(group_indices, values, None, value_fn);
             self.seen_values_size = total_num_groups;
         } else {
@@ -158,10 +155,7 @@ impl NullState {
         let data = values.values();
         assert_eq!(data.len(), group_indices.len());
 
-        if self.seen_values.capacity() == 0
-            && opt_filter.is_none()
-            && values.null_count() == 0
-        {
+        if self.all_seen() == 0 && opt_filter.is_none() && values.null_count() == 0 {
             group_indices
                 .iter()
                 .zip(data.iter())
@@ -170,8 +164,7 @@ impl NullState {
 
             return;
         }
-        let prev_seen: bool =
-            self.seen_values.capacity() == 0 && self.seen_values_size > 0;
+        let prev_seen: bool = self.all_seen() && self.seen_values_size > 0;
         // ensure the seen_values is big enough (start everything at
         // "not seen" valid)
         let seen_values =