Skip to content

Commit da36ad8

Browse files
authored
Fix data for tpch_csv and tpch_csv10 (#19034)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change When I try to ensure the data is available for the tpch_csv benchmark, I get an error: ``` $ ./benchmarks/bench.sh data tpch_csv ``` ``` *************************** DataFusion Benchmark Runner and Data Generator COMMAND: data BENCHMARK: tpch_csv DATA_DIR: /Users/andrewlamb/Software/datafusion2/benchmarks/data CARGO_COMMAND: cargo run --release PREFER_HASH_JOIN: true *************************** Error: unknown benchmark 'tpch_csv' for data generation ``` ## What changes are included in this PR? Fix the runner script to correctly create the data ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 2c24deb commit da36ad8

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

benchmarks/bench.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,13 +209,21 @@ main() {
209209
# same data as for tpch
210210
data_tpch "1"
211211
;;
212+
tpch_csv)
213+
# same data as for tpch
214+
data_tpch "1"
215+
;;
212216
tpch10)
213217
data_tpch "10"
214218
;;
215219
tpch_mem10)
216220
# same data as for tpch10
217221
data_tpch "10"
218222
;;
223+
tpch_csv10)
224+
# same data as for tpch10
225+
data_tpch "10"
226+
;;
219227
clickbench_1)
220228
data_clickbench_1
221229
;;

0 commit comments

Comments
 (0)