File tree Expand file tree Collapse file tree 3 files changed +4
-1
lines changed
Expand file tree Collapse file tree 3 files changed +4
-1
lines changed Original file line number Diff line number Diff line change @@ -321,6 +321,7 @@ impl TryFrom<&protobuf::Field> for Field {
321321 fn try_from ( field : & protobuf:: Field ) -> Result < Self , Self :: Error > {
322322 let datatype = field. arrow_type . as_deref ( ) . required ( "arrow_type" ) ?;
323323 let field = if field. dict_id != 0 {
324+ // https://github.com/apache/datafusion/issues/14173
324325 #[ allow( deprecated) ]
325326 Self :: new_dict (
326327 field. name . as_str ( ) ,
@@ -436,6 +437,7 @@ impl TryFrom<&protobuf::ScalarValue> for ScalarValue {
436437 let id = dict_batch. id ( ) ;
437438
438439 let fields_using_this_dictionary = {
440+ // See https://github.com/apache/datafusion/issues/14173
439441 #[ allow( deprecated) ]
440442 schema. fields_with_dict_id ( id)
441443 } ;
Original file line number Diff line number Diff line change @@ -98,6 +98,7 @@ impl TryFrom<&Field> for protobuf::Field {
9898 children : Vec :: new ( ) ,
9999 metadata : field. metadata ( ) . clone ( ) ,
100100 #[ allow( deprecated) ]
101+ // See https://github.com/apache/datafusion/issues/14173 to remove deprecated dict_id
101102 dict_id : field. dict_id ( ) . unwrap_or ( 0 ) ,
102103 dict_ordered : field. dict_is_ordered ( ) . unwrap_or ( false ) ,
103104 } )
Original file line number Diff line number Diff line change @@ -1815,7 +1815,7 @@ fn round_trip_datatype() {
18151815 }
18161816}
18171817
1818- // TODO file a ticket about handling deprecated dict_id attributes
1818+ // See https://github.com/apache/datafusion/issues/14173 to remove deprecated dict_id
18191819#[ allow( deprecated) ]
18201820#[ test]
18211821fn roundtrip_dict_id ( ) -> Result < ( ) > {
You can’t perform that action at this time.
0 commit comments