Commit f9c030a
Automatically download tpcds benchmark data to the right place (#19244)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #19243
## Rationale for this change
I want to be able to run tpcdb benchmarks added by @comphead as part of
my benchmark
automation scripts. To do so I need to be able to run `bench.sh data
tpchds` and have
it automatically generate the data if it is not present.
Right now the data generation step is manual.
```shell
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ ./benchmarks/bench.sh data tpcds
***************************
DataFusion Benchmark Runner and Data Generator
COMMAND: data
BENCHMARK: tpcds
DATA_DIR: /Users/andrewlamb/Software/datafusion/benchmarks/data
CARGO_COMMAND: cargo run --release
PREFER_HASH_JOIN: true
***************************
For TPC-DS data generation, please clone the datafusion-benchmarks repository:
git clone https://github.com/apache/datafusion-benchmarks
```
And I think it takes some more post processing steps (which is what
@mbutrovich hit)
## What changes are included in this PR?
1. Update the data setup portion to automatically download the contents
from github and extract it in the correct location
## Are these changes tested?
I tested this manually on my mac laptop by deleting the data directory
and running the script again, and deleting the web_*.parquet files to
ensure they are re-downloaded correctly.
```shell
./benchmarks/bench.sh data tpcds
./benchmarks/bench.sh run tpcds
```
I also tested on my benchmark machine (linux)
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
---------
Co-authored-by: Martin Grigorov <[email protected]>1 parent a3b3eb5 commit f9c030a
1 file changed
+19
-28
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
629 | 629 | | |
630 | 630 | | |
631 | 631 | | |
632 | | - | |
| 632 | + | |
633 | 633 | | |
634 | | - | |
635 | | - | |
636 | | - | |
637 | | - | |
638 | | - | |
639 | | - | |
640 | | - | |
641 | | - | |
642 | | - | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
643 | 648 | | |
644 | | - | |
645 | | - | |
646 | | - | |
647 | | - | |
| 649 | + | |
648 | 650 | | |
649 | 651 | | |
650 | 652 | | |
| |||
682 | 684 | | |
683 | 685 | | |
684 | 686 | | |
685 | | - | |
686 | | - | |
687 | | - | |
688 | | - | |
689 | | - | |
690 | | - | |
691 | | - | |
692 | | - | |
693 | | - | |
694 | | - | |
695 | | - | |
| 687 | + | |
696 | 688 | | |
697 | | - | |
698 | | - | |
699 | | - | |
| 689 | + | |
| 690 | + | |
700 | 691 | | |
701 | 692 | | |
702 | 693 | | |
| |||
0 commit comments