Revert is_sorted removal, deprecate instead#14388
Merged
alamb merged 3 commits intoapache:mainfrom Jan 31, 2025
Merged
Conversation
This reverts commit 29e9a1c.
Contributor
Author
|
Thanks again @andygrove |
cj-zhukov
pushed a commit
to cj-zhukov/datafusion
that referenced
this pull request
Feb 3, 2025
* Revert "removed (apache#14370)" This reverts commit 29e9a1c. * Restore/Deprecate is_sorted * Update datafusion/common/src/utils/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
45.0.0#14008Rationale for this change
As @andygrove mentioned https://github.com/apache/datafusion/pull/14370/files#r1937564039 we should deprecate public APIs rather than remove them immediately
What changes are included in this PR?
is_sortedinsteadAre these changes tested?
By the compiler
Are there any user-facing changes?