Add custom nullability to SparkMakeInterval #19606
Closed
+16
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #19155
Rationale for this change
Spark's
make_intervalfunction needs to properly report output nullability:Currently,
return_typeonly reports the data type, not nullability information.What changes are included in this PR?
Added
return_field_from_argsimplementation toSparkMakeInterval:nullable = false(always returns 0 interval)nullable = true(null inputs or overflow possible)How are these changes tested?
All existing unit tests pass:
Are these changes safe?
Yes - this only adds metadata about nullability, doesn't change the actual function behavior.