[Chore] Remove unused code in api-server (#17871)

Author: ruanwenjun

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/ApiApplicationServer.java

@@ -22,7 +22,6 @@
 import org.apache.dolphinscheduler.common.lifecycle.ServerLifeCycleManager;
 import org.apache.dolphinscheduler.common.thread.DefaultUncaughtExceptionHandler;
 import org.apache.dolphinscheduler.dao.DaoConfiguration;
-import org.apache.dolphinscheduler.dao.PluginDao;
 import org.apache.dolphinscheduler.plugin.datasource.api.plugin.DataSourceProcessorProvider;
 import org.apache.dolphinscheduler.plugin.storage.api.StorageConfiguration;
 import org.apache.dolphinscheduler.plugin.task.api.TaskPluginManager;
@@ -31,7 +30,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.boot.context.event.ApplicationReadyEvent;
@@ -49,9 +47,6 @@
 @SpringBootApplication
 public class ApiApplicationServer {
 
-    @Autowired
-    private PluginDao pluginDao;
-
     public static void main(String[] args) {
         ApiServerMetrics.registerUncachedException(DefaultUncaughtExceptionHandler::getUncaughtExceptionCount);
         Thread.setDefaultUncaughtExceptionHandler(DefaultUncaughtExceptionHandler.getInstance());

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java

@@ -561,7 +561,6 @@ public enum Status {
             "查询工作流自定义变量信息错误"),
 
     NO_CURRENT_OPERATING_PERMISSION(1400001, "The current user does not have this permission.", "当前用户无此权限"),
-    FUNCTION_DISABLED(1400002, "The current feature is disabled.", "当前功能已被禁用"),
     SCHEDULE_TIME_NUMBER_EXCEED(1400003, "The number of complement dates exceed 100.", "补数日期个数超过100"),
     DESCRIPTION_TOO_LONG_ERROR(1400004, "description is too long error", "描述过长"),
     DELETE_WORKER_GROUP_BY_ID_FAIL_ENV(1400005,

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/k8s/K8sClientService.java

@@ -23,20 +23,16 @@
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
-import org.yaml.snakeyaml.Yaml;
 
 import io.fabric8.kubernetes.api.model.Namespace;
 import io.fabric8.kubernetes.api.model.NamespaceList;
-import io.fabric8.kubernetes.api.model.ObjectMeta;
-import io.fabric8.kubernetes.client.KubernetesClient;
 
 /**
  * Encapsulates all client-related operations, not involving the db
  */
 @Component
 public class K8sClientService {
 
-    private static Yaml yaml = new Yaml();
     @Autowired
     private K8sManager k8sManager;
 
@@ -48,20 +44,6 @@ public void upsertNamespaceAndResourceToK8s(K8sNamespace k8sNamespace) {
         }
     }
 
-    public Optional<Namespace> deleteNamespaceToK8s(String name, Long clusterCode) {
-        Optional<Namespace> result = getNamespaceFromK8s(name, clusterCode);
-        if (result.isPresent()) {
-            KubernetesClient client = k8sManager.getK8sClient(clusterCode);
-            Namespace body = new Namespace();
-            ObjectMeta meta = new ObjectMeta();
-            meta.setNamespace(name);
-            meta.setName(name);
-            body.setMetadata(meta);
-            client.namespaces().delete(body);
-        }
-        return getNamespaceFromK8s(name, clusterCode);
-    }
-
     private Optional<Namespace> getNamespaceFromK8s(String name, Long clusterCode) {
         NamespaceList listNamespace =
                 k8sManager.getK8sClient(clusterCode).namespaces().list();

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/metrics/ApiServerMetrics.java

@@ -17,15 +17,13 @@
 
 package org.apache.dolphinscheduler.api.metrics;
 
-import java.util.concurrent.TimeUnit;
 import java.util.function.Supplier;
 
 import lombok.experimental.UtilityClass;
 import io.micrometer.core.instrument.Counter;
 import io.micrometer.core.instrument.DistributionSummary;
 import io.micrometer.core.instrument.Gauge;
 import io.micrometer.core.instrument.Metrics;
-import io.micrometer.core.instrument.Timer;
 
 @UtilityClass
 public class ApiServerMetrics {
@@ -75,13 +73,6 @@ public class ApiServerMetrics {
                     .description("size of download resource files on api")
                     .register(Metrics.globalRegistry);
 
-    static {
-        Timer.builder("ds.api.response.time")
-                .tag("user.id", "dummy")
-                .description("response time on api")
-                .register(Metrics.globalRegistry);
-    }
-
     public void incApiRequestCount() {
         apiRequestCounter.increment();
     }
@@ -110,12 +101,6 @@ public void recordApiResourceDownloadSize(final long size) {
         apiResourceDownloadSizeDistribution.record(size);
     }
 
-    public void recordApiResponseTime(final long milliseconds, final int userId) {
-        Metrics.globalRegistry.timer(
-                "ds.api.response.time",
-                "user.id", String.valueOf(userId)).record(milliseconds, TimeUnit.MILLISECONDS);
-    }
-
     public void cleanUpApiResponseTimeMetricsByUserId(final int userId) {
         Metrics.globalRegistry.remove(
                 Metrics.globalRegistry.timer(

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/PermissionCheck.java

@@ -61,31 +61,6 @@ public class PermissionCheck<T> {
      */
     private int userId;
 
-    /**
-     * permission check
-     *
-     * @param authorizationType authorization type
-     * @param processService process dao
-     */
-    public PermissionCheck(AuthorizationType authorizationType, ProcessService processService) {
-        this.authorizationType = authorizationType;
-        this.processService = processService;
-    }
-
-    /**
-     * permission check
-     */
-    public PermissionCheck(AuthorizationType authorizationType, ProcessService processService, T[] needChecks,
-                           int userId) {
-        this.authorizationType = authorizationType;
-        this.processService = processService;
-        this.needChecks = needChecks;
-        this.userId = userId;
-    }
-
-    /**
-     * permission check
-     */
     public PermissionCheck(AuthorizationType authorizationType, ProcessService processService, T[] needChecks,
                            int userId, Logger logger) {
         this.authorizationType = authorizationType;
@@ -95,26 +70,6 @@ public PermissionCheck(AuthorizationType authorizationType, ProcessService proce
         this.logger = logger;
     }
 
-    /**
-     * permission check
-     */
-    public PermissionCheck(AuthorizationType authorizationType, ProcessService processService,
-                           List<ResourceInfo> resourceList, int userId, Logger logger) {
-        this.authorizationType = authorizationType;
-        this.processService = processService;
-        this.resourceList = resourceList;
-        this.userId = userId;
-        this.logger = logger;
-    }
-
-    public AuthorizationType getAuthorizationType() {
-        return authorizationType;
-    }
-
-    public void setAuthorizationType(AuthorizationType authorizationType) {
-        this.authorizationType = authorizationType;
-    }
-
     public ProcessService getProcessService() {
         return processService;
     }
@@ -123,14 +78,6 @@ public void setProcessService(ProcessService processService) {
         this.processService = processService;
     }
 
-    public T[] getNeedChecks() {
-        return needChecks;
-    }
-
-    public void setNeedChecks(T[] needChecks) {
-        this.needChecks = needChecks;
-    }
-
     public int getUserId() {
         return userId;
     }
@@ -147,20 +94,6 @@ public void setResourceList(List<ResourceInfo> resourceList) {
         this.resourceList = resourceList;
     }
 
-    /**
-     * has permission
-     *
-     * @return true if has permission
-     */
-    public boolean hasPermission() {
-        try {
-            checkPermission();
-            return true;
-        } catch (Exception e) {
-            return false;
-        }
-    }
-
     /**
      * check permission
      *

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckService.java

@@ -17,6 +17,8 @@
 
 package org.apache.dolphinscheduler.api.permission;
 
+import org.apache.dolphinscheduler.common.enums.AuthorizationType;
+
 import java.util.Set;
 
 import org.slf4j.Logger;
@@ -50,13 +52,7 @@ public interface ResourcePermissionCheckService<T> {
      * @param logger
      * @return
      */
-    boolean operationPermissionCheck(Object authorizationType, Integer userId,
-                                     String permissionKey, Logger logger);
-
-    /**
-     * functionDisabled
-     * @return
-     */
-    boolean functionDisabled();
+    boolean operationPermissionCheck(AuthorizationType authorizationType, Integer userId, String permissionKey,
+                                     Logger logger);
 
 }

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java

@@ -44,7 +44,6 @@
 import org.apache.dolphinscheduler.dao.mapper.TenantMapper;
 import org.apache.dolphinscheduler.dao.repository.UserDao;
 import org.apache.dolphinscheduler.dao.repository.WorkerGroupDao;
-import org.apache.dolphinscheduler.service.process.ProcessService;
 
 import java.util.Arrays;
 import java.util.Collections;
@@ -70,9 +69,9 @@ public class ResourcePermissionCheckServiceImpl
             ApplicationContextAware {
 
     @Autowired
-    private ProcessService processService;
+    private UserDao userDao;
 
-    public static final Map<AuthorizationType, ResourceAcquisitionAndPermissionCheck<?>> RESOURCE_LIST_MAP =
+    static final Map<AuthorizationType, ResourceAcquisitionAndPermissionCheck<?>> RESOURCE_LIST_MAP =
             new ConcurrentHashMap<>();
 
     @Override
@@ -100,9 +99,9 @@ public boolean resourcePermissionCheck(Object authorizationType, Object[] needCh
     }
 
     @Override
-    public boolean operationPermissionCheck(Object authorizationType, Integer userId,
-                                            String permissionKey, Logger logger) {
-        User user = processService.getUserById(userId);
+    public boolean operationPermissionCheck(AuthorizationType authorizationType, Integer userId, String permissionKey,
+                                            Logger logger) {
+        User user = userDao.queryById(userId);
         if (user == null) {
             logger.error("User does not exist, userId:{}.", userId);
             return false;
@@ -113,14 +112,9 @@ public boolean operationPermissionCheck(Object authorizationType, Integer userId
         return RESOURCE_LIST_MAP.get(authorizationType).permissionCheck(userId, permissionKey, logger);
     }
 
-    @Override
-    public boolean functionDisabled() {
-        return false;
-    }
-
     @Override
     public Set<Object> userOwnedResourceIdsAcquisition(Object authorizationType, Integer userId, Logger logger) {
-        User user = processService.getUserById(userId);
+        User user = userDao.queryById(userId);
         if (user == null) {
             logger.error("User does not exist, userId:{}.", userId);
             return Collections.emptySet();

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/BaseServiceImpl.java

@@ -124,19 +124,6 @@ public boolean check(Map<String, Object> result, boolean bool, Status userNoOper
         return false;
     }
 
-    /**
-     * create tenant dir if not exists
-     *
-     * @param tenantCode tenant code
-     * @throws IOException if hdfs operation exception
-     */
-    // @Override
-    // public void createTenantDirIfNotExists(String tenantCode) throws IOException {
-    // String resourcePath = HadoopUtils.getHdfsResDir(tenantCode);
-    // // init resource path
-    // HadoopUtils.getInstance().mkdir(tenantCode,resourcePath);
-    // }
-
     /**
      * Verify that the operator has permissions
      *