Skip to content

Commit 428c986

Browse files
njnu-seafish苏义超SbloodyS
authored
[Fix-17838][Bug] [ApiServer] Remove WAIT_TO_RUN and add FAILOVER while querying workflow instances (#17839)
* remove WAIT_TO_RUN and add FAILOVER * update chinese name * remove unused states from ui * pnpm run lint * restore fix --------- Co-authored-by: 苏义超 <suyc@chinatelecom.cn> Co-authored-by: xiangzihao <460888207@qq.com>
1 parent 36cc9c2 commit 428c986

File tree

9 files changed

+11
-29
lines changed

9 files changed

+11
-29
lines changed

docs/docs/en/guide/project/workflow-instance.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ figure:
5656
|-----------------------------------|------|-------|------|-------|----------------|--------|-------------|
5757
| SUBMITTED_SUCCESS | | ||| | ||
5858
| SERIAL_WAIT | | || | | ||
59-
| WAIT_TO_RUN | | | | | | ||
59+
| FAILOVER | | | | | | ||
6060
| Executing | | ||| | ||
6161
| READY PAUSE | | | | | | ||
6262
| PAUSE ||| | ||||

dolphinscheduler-ui/src/common/common.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
StopOutlined,
3131
IssuesCloseOutlined,
3232
SendOutlined,
33-
HourglassOutlined
33+
SwapOutlined
3434
} from '@vicons/antd'
3535
import { format, parseISO } from 'date-fns'
3636
import _ from 'lodash'
@@ -112,10 +112,6 @@ export const runningType = (t: any) => [
112112
desc: `${t('project.workflow.stop')}`,
113113
code: 'STOP'
114114
},
115-
{
116-
desc: `${t('project.workflow.recovery_waiting_thread')}`,
117-
code: 'RECOVER_WAITING_THREAD'
118-
},
119115
{
120116
desc: `${t('project.workflow.recover_serial_wait')}`,
121117
code: 'RECOVER_SERIAL_WAIT'
@@ -368,13 +364,13 @@ export const workflowExecutionState = (
368364
isSpin: true,
369365
classNames: 'serial_wait'
370366
},
371-
WAIT_TO_RUN: {
367+
FAILOVER: {
372368
id: 18,
373-
desc: `${t('project.workflow.wait_to_run')}`,
369+
desc: `${t('project.workflow.failover')}`,
374370
color: '#5102ce',
375-
icon: HourglassOutlined,
371+
icon: SwapOutlined,
376372
isSpin: false,
377-
classNames: 'wait_to_run'
373+
classNames: 'failover'
378374
}
379375
})
380376

dolphinscheduler-ui/src/common/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export type IWorkflowExecutionState =
3939
| 'FAILURE'
4040
| 'SUCCESS'
4141
| 'SERIAL_WAIT'
42-
| 'WAIT_TO_RUN'
42+
| 'FAILOVER'
4343

4444
export type ITaskStateConfig = {
4545
[key in ITaskState]: {

dolphinscheduler-ui/src/locales/en_US/home.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,10 @@ export default {
3131
success: 'SUCCESS',
3232
need_fault_tolerance: 'NEED_FAULT_TOLERANCE',
3333
kill: 'KILL',
34-
waiting_thread: 'WAITING_THREAD',
3534
waiting_depend: 'WAITING_DEPEND',
3635
delay_execution: 'DELAY_EXECUTION',
3736
forced_success: 'FORCED_SUCCESS',
3837
serial_wait: 'SERIAL_WAIT',
3938
dispatch: 'DISPATCH',
40-
ready_block: 'READY_BLOCK',
41-
block: 'BLOCK',
42-
wait_to_run: 'WAIT_TO_RUN',
4339
failover: 'FAILOVER'
4440
}

dolphinscheduler-ui/src/locales/en_US/project.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@ export default {
174174
rerun: 'Rerun',
175175
stop: 'Stop',
176176
pause: 'Pause',
177-
recovery_waiting_thread: 'Recovery waiting thread',
178177
recover_serial_wait: 'Recover serial wait',
179178
execute_task: 'Execute the specified task',
180179
dynamic_generation: 'Dynamic Generation',
@@ -190,7 +189,6 @@ export default {
190189
failed: 'Failed',
191190
need_fault_tolerance: 'Need fault tolerance',
192191
kill: 'Kill',
193-
waiting_for_thread: 'Waiting for thread',
194192
waiting_for_dependence: 'Waiting for dependence',
195193
waiting_for_dependency_to_complete: 'Waiting for dependency to complete',
196194
delay_execution: 'Delay execution',
@@ -230,7 +228,7 @@ export default {
230228
'Can not find any relations of workflows.',
231229
workflow_relation_no_data_result_desc:
232230
'There is not any workflows. Please create a workflow, and then visit this page again.',
233-
wait_to_run: 'Wait to run',
231+
failover: 'Failover',
234232
confirm_to_online: 'Confirm to make the workflow online?',
235233
confirm_to_offline: 'Confirm to make the workflow offline?',
236234
time_to_online: 'Confirm to make the Scheduler online?',

dolphinscheduler-ui/src/locales/zh_CN/home.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,10 @@ export default {
3131
success: '成功',
3232
need_fault_tolerance: '需要容错',
3333
kill: 'KILL',
34-
waiting_thread: '等待线程',
3534
waiting_depend: '等待依赖完成',
3635
delay_execution: '延时执行',
3736
forced_success: '强制成功',
3837
serial_wait: '串行等待',
3938
dispatch: '派发',
40-
ready_block: '准备阻断',
41-
block: '阻断',
42-
wait_to_run: '等待执行',
4339
failover: '恢复容错'
4440
}

dolphinscheduler-ui/src/locales/zh_CN/project.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default {
4444
total_items: '总条目为'
4545
},
4646
workflow: {
47-
on_line: '线上',
47+
on_line: '上线',
4848
test: '测试',
4949
operating_environment: '运行环境',
5050
workflow_relation: '工作流关系',
@@ -173,7 +173,6 @@ export default {
173173
rerun: '重跑',
174174
stop: '停止',
175175
pause: '暂停',
176-
recovery_waiting_thread: '恢复等待线程',
177176
recover_serial_wait: '串行恢复',
178177
execute_task: '执行指定任务',
179178
dynamic_generation: '动态生成',
@@ -189,7 +188,6 @@ export default {
189188
failed: '失败',
190189
need_fault_tolerance: '需要容错',
191190
kill: 'Kill',
192-
waiting_for_thread: '等待线程',
193191
waiting_for_dependence: '等待依赖',
194192
waiting_for_dependency_to_complete: '等待依赖完成',
195193
delay_execution: '延时执行',
@@ -228,7 +226,7 @@ export default {
228226
workflow_relation_no_data_result_title: '工作流关系不存在',
229227
workflow_relation_no_data_result_desc:
230228
'目前没有任何工作流,请先创建工作流,再访问该页面',
231-
wait_to_run: '等待执行',
229+
failover: '恢复容错',
232230
confirm_to_online: '是否确定上线该工作流?',
233231
confirm_to_offline: '是否确定下线该工作流?',
234232
time_to_online: '是否确定上线该定时?',
@@ -247,7 +245,7 @@ export default {
247245
warning_too_large_parallelism_number: '并行度设置太大了, 最好不要超过10.'
248246
},
249247
task: {
250-
on_line: '线上',
248+
on_line: '上线',
251249
test: '测试',
252250
operating_environment: '运行环境',
253251
cancel_full_screen: '取消全屏',

dolphinscheduler-ui/src/service/modules/executors/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ type Exec =
3434
| 'REPEAT_RUNNING'
3535
| 'PAUSE'
3636
| 'STOP'
37-
| 'RECOVER_WAITING_THREAD'
3837

3938
interface ExecuteReq {
4039
executeType: Execute

dolphinscheduler-ui/src/views/projects/workflow/components/dag/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ export default defineComponent({
143143
const menuDisplay = computed(() => {
144144
if (props.instance) {
145145
return (
146-
props.instance.state === 'WAITING_THREAD' ||
147146
props.instance.state === 'SUCCESS' ||
148147
props.instance.state === 'PAUSE' ||
149148
props.instance.state === 'FAILURE' ||

0 commit comments

Comments
 (0)