Skip to content

Commit 550884b

Browse files
authored
[Chore] Enhances code readability and maintainability (#17894)
1 parent b093d02 commit 550884b

File tree

1 file changed

+4
-4
lines changed
  • dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java

1 file changed

+4
-4
lines changed

dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
import org.apache.commons.lang3.StringUtils;
4141

42-
import java.io.File;
42+
import java.nio.file.Paths;
4343
import java.util.Map;
4444

4545
import lombok.extern.slf4j.Slf4j;
@@ -138,7 +138,7 @@ protected String buildJarCommand() {
138138
.getResourceAbsolutePathInLocal();
139139
StringBuilder builder = new StringBuilder();
140140
builder.append(getJavaCommandPath())
141-
.append("java").append(Constants.SPACE)
141+
.append(Constants.SPACE)
142142
.append(javaParameters.getJvmArgs().trim()).append(Constants.SPACE)
143143
.append(buildResourcePath()).append(Constants.SPACE)
144144
.append("-jar").append(Constants.SPACE)
@@ -167,7 +167,7 @@ protected String buildNormalJarCommand() {
167167
}
168168
StringBuilder builder = new StringBuilder();
169169
builder.append(getJavaCommandPath())
170-
.append("java").append(Constants.SPACE)
170+
.append(Constants.SPACE)
171171
.append(javaParameters.getJvmArgs().trim()).append(Constants.SPACE)
172172
.append(buildResourcePath()).append(Constants.SPACE)
173173
.append(mainJarName).append(Constants.SPACE)
@@ -221,7 +221,7 @@ protected String buildResourcePath() {
221221
* @return String
222222
**/
223223
private String getJavaCommandPath() {
224-
return JAVA_HOME_VAR + File.separator + "bin" + File.separator;
224+
return Paths.get(JAVA_HOME_VAR, "bin", "java").toString();
225225
}
226226

227227
private String parseParameter(String script) {

0 commit comments

Comments
 (0)