Skip to content

Commit b9b6d51

Browse files
authored
[Chore] Remove unused code in ProcessService (#17391)
1 parent 5a93624 commit b9b6d51

File tree

4 files changed

+0
-767
lines changed

4 files changed

+0
-767
lines changed

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,6 @@ private TaskDefinitionLog updateTask(User loginUser, long projectCode, long task
399399
taskDefinitionToUpdate.setUserId(taskDefinition.getUserId());
400400
taskDefinitionToUpdate.setVersion(++version);
401401
taskDefinitionToUpdate.setTaskType(taskDefinitionToUpdate.getTaskType().toUpperCase());
402-
taskDefinitionToUpdate.setResourceIds(processService.getResourceIds(taskDefinitionToUpdate));
403402
taskDefinitionToUpdate.setUpdateTime(now);
404403
int update = taskDefinitionMapper.updateById(taskDefinitionToUpdate);
405404
taskDefinitionToUpdate.setOperator(loginUser.getId());

dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -18,63 +18,42 @@
1818
package org.apache.dolphinscheduler.service.process;
1919

2020
import org.apache.dolphinscheduler.common.enums.AuthorizationType;
21-
import org.apache.dolphinscheduler.common.enums.TaskGroupQueueStatus;
2221
import org.apache.dolphinscheduler.common.graph.DAG;
2322
import org.apache.dolphinscheduler.common.model.TaskNodeRelation;
24-
import org.apache.dolphinscheduler.dao.entity.Command;
2523
import org.apache.dolphinscheduler.dao.entity.DagData;
2624
import org.apache.dolphinscheduler.dao.entity.DataSource;
2725
import org.apache.dolphinscheduler.dao.entity.Schedule;
28-
import org.apache.dolphinscheduler.dao.entity.TaskDefinition;
2926
import org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog;
30-
import org.apache.dolphinscheduler.dao.entity.TaskGroupQueue;
3127
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
3228
import org.apache.dolphinscheduler.dao.entity.User;
3329
import org.apache.dolphinscheduler.dao.entity.WorkflowDefinition;
3430
import org.apache.dolphinscheduler.dao.entity.WorkflowDefinitionLog;
3531
import org.apache.dolphinscheduler.dao.entity.WorkflowInstance;
3632
import org.apache.dolphinscheduler.dao.entity.WorkflowTaskRelation;
3733
import org.apache.dolphinscheduler.dao.entity.WorkflowTaskRelationLog;
38-
import org.apache.dolphinscheduler.service.exceptions.CronParseException;
3934
import org.apache.dolphinscheduler.service.model.TaskNode;
4035

4136
import java.util.List;
42-
import java.util.Map;
4337
import java.util.Optional;
4438

4539
public interface ProcessService {
4640

47-
WorkflowInstance constructWorkflowInstance(Command command,
48-
String host) throws CronParseException;
49-
5041
Optional<WorkflowInstance> findWorkflowInstanceDetailById(int workflowInstanceId);
5142

5243
WorkflowInstance findWorkflowInstanceById(int workflowInstanceId);
5344

5445
WorkflowDefinition findWorkflowDefinition(Long workflowDefinitionCode, int workflowDefinitionVersion);
5546

56-
WorkflowDefinition findWorkflowDefinitionByCode(Long workflowDefinitionCode);
57-
5847
int deleteWorkflowInstanceById(int workflowInstanceId);
5948

60-
int deleteAllSubWorkflowByParentId(int workflowInstanceId);
61-
62-
void removeTaskLogFile(Integer workflowInstanceId);
63-
6449
List<Long> findAllSubWorkflowDefinitionCode(long workflowDefinitionCode);
6550

6651
String getTenantForWorkflow(String tenantCode, int userId);
6752

68-
int deleteWorkflowMapByParentId(int parentWorkflowId);
69-
7053
WorkflowInstance findSubWorkflowInstance(Integer parentWorkflowInstanceId, Integer parentTaskId);
7154

7255
WorkflowInstance findParentWorkflowInstance(Integer subWorkflowInstanceId);
7356

74-
void changeOutParam(TaskInstance taskInstance);
75-
76-
Schedule querySchedule(int id);
77-
7857
List<Schedule> queryReleaseSchedulerListByWorkflowDefinitionCode(long workflowDefinitionCode);
7958

8059
DataSource findDataSourceById(int id);
@@ -83,16 +62,12 @@ WorkflowInstance constructWorkflowInstance(Command command,
8362

8463
User getUserById(int userId);
8564

86-
String formatTaskAppId(TaskInstance taskInstance);
87-
8865
int switchVersion(WorkflowDefinition workflowDefinition, WorkflowDefinitionLog workflowDefinitionLog);
8966

9067
int switchWorkflowTaskRelationVersion(WorkflowDefinition workflowDefinition);
9168

9269
int switchTaskDefinitionVersion(long taskCode, int taskVersion);
9370

94-
String getResourceIds(TaskDefinition taskDefinition);
95-
9671
int saveTaskDefine(User operator, long projectCode, List<TaskDefinitionLog> taskDefinitionLogs, Boolean syncDefine);
9772

9873
int saveWorkflowDefine(User operator, WorkflowDefinition workflowDefinition, Boolean syncDefine,
@@ -113,16 +88,8 @@ int saveTaskRelation(User operator, long projectCode, long workflowDefinitionCod
11388
List<TaskNode> transformTask(List<WorkflowTaskRelation> taskRelationList,
11489
List<TaskDefinitionLog> taskDefinitionLogs);
11590

116-
TaskGroupQueue insertIntoTaskGroupQueue(Integer taskId,
117-
String taskName,
118-
Integer groupId,
119-
Integer workflowInstanceId,
120-
Integer priority,
121-
TaskGroupQueueStatus status);
122-
12391
String findConfigYamlByName(String clusterName);
12492

12593
void forceWorkflowInstanceSuccessByTaskInstanceId(TaskInstance taskInstance);
12694

127-
void setGlobalParamIfCommanded(WorkflowDefinition workflowDefinition, Map<String, String> cmdParam);
12895
}

0 commit comments

Comments
 (0)