[Improvement-17311][RPC] Validate the args type in RPC method (#17312)

Author: ruanwenjun

dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/server/JdkDynamicServerHandler.java

@@ -33,6 +33,9 @@
 import java.util.concurrent.RejectedExecutionException;
 
 import lombok.extern.slf4j.Slf4j;
+
+import com.google.common.collect.Lists;
+
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelConfig;
 import io.netty.channel.ChannelHandler;
@@ -100,6 +103,11 @@ private void processReceived(final Channel channel, final Transporter transporte
                     if (standardRpcRequest.getArgs() == null || standardRpcRequest.getArgs().length == 0) {
                         args = null;
                     } else {
+                        if (!methodInvoker.isParameterTypeValidated(standardRpcRequest.getArgsTypes())) {
+                            throw new IllegalArgumentException(
+                                    "Parameter types: " + Lists.newArrayList(standardRpcRequest.getArgsTypes())
+                                            + " do not match the method signature.");
+                        }
                         args = new Object[standardRpcRequest.getArgs().length];
                         for (int i = 0; i < standardRpcRequest.getArgs().length; i++) {
                             args[i] = JsonSerializer.deserialize(standardRpcRequest.getArgs()[i],

dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/server/ServerMethodInvoker.java

@@ -25,4 +25,5 @@ interface ServerMethodInvoker {
 
     Object invoke(final Object... arg) throws Throwable;
 
+    boolean isParameterTypeValidated(Class<?>[] argsTypes);
 }

dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/server/ServerMethodInvokerImpl.java

@@ -19,6 +19,9 @@
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+import java.util.List;
+
+import com.google.common.collect.Lists;
 
 class ServerMethodInvokerImpl implements ServerMethodInvoker {
 
@@ -28,10 +31,13 @@ class ServerMethodInvokerImpl implements ServerMethodInvoker {
 
     private final String methodIdentify;
 
+    private final List<Class<?>> parameterTypes;
+
     ServerMethodInvokerImpl(Object serviceBean, Method method) {
         this.serviceBean = serviceBean;
         this.method = method;
         this.methodIdentify = method.toGenericString();
+        this.parameterTypes = Lists.newArrayList(method.getParameterTypes());
     }
 
     @Override
@@ -44,6 +50,26 @@ public Object invoke(Object... args) throws Throwable {
         }
     }
 
+    @Override
+    public boolean isParameterTypeValidated(Class<?>[] argsTypes) {
+        if (argsTypes == null || argsTypes.length == 0) {
+            return parameterTypes.isEmpty();
+        }
+        if (parameterTypes.size() != argsTypes.length) {
+            return false;
+        }
+        for (int i = 0; i < parameterTypes.size(); i++) {
+            Class<?> argType = argsTypes[i];
+            if (argType == null) {
+                continue;
+            }
+            if (!parameterTypes.get(i).isAssignableFrom(argType)) {
+                return false;
+            }
+        }
+        return true;
+    }
+
     @Override
     public String getMethodIdentify() {
         return methodIdentify;

dolphinscheduler-extract/dolphinscheduler-extract-base/src/test/java/org/apache/dolphinscheduler/extract/base/client/ClientsTest.java

@@ -24,14 +24,17 @@
 import org.apache.dolphinscheduler.extract.base.RpcMethod;
 import org.apache.dolphinscheduler.extract.base.RpcMethodRetryStrategy;
 import org.apache.dolphinscheduler.extract.base.RpcService;
+import org.apache.dolphinscheduler.extract.base.config.NettyClientConfig;
 import org.apache.dolphinscheduler.extract.base.config.NettyServerConfig;
 import org.apache.dolphinscheduler.extract.base.exception.MethodInvocationException;
 import org.apache.dolphinscheduler.extract.base.exception.RemoteException;
 import org.apache.dolphinscheduler.extract.base.server.SpringServerMethodInvokerDiscovery;
+import org.apache.dolphinscheduler.extract.base.utils.Host;
 
 import org.apache.commons.lang3.RandomUtils;
 import org.apache.commons.lang3.StringUtils;
 
+import java.lang.reflect.Method;
 import java.time.Duration;
 
 import org.awaitility.Awaitility;
@@ -98,6 +101,20 @@ public void testVoid() {
         assertDoesNotThrow(proxyClient::voidMethod);
     }
 
+    @Test
+    public void testIllegalArgsType() throws Throwable {
+        final Method method = IService.class.getMethod("ping", String.class);
+        final SyncClientMethodInvoker methodInvoker = new SyncClientMethodInvoker(Host.of(serverAddress), method,
+                new NettyRemotingClient(new NettyClientConfig()));
+        final Integer[] args = {1}; // Invalid argument type, should be String;
+        MethodInvocationException methodInvocationException = assertThrows(
+                MethodInvocationException.class,
+                () -> methodInvoker.invoke(null, method, args));
+        assertEquals("Parameter types: [class java.lang.Integer] do not match the method signature.",
+                methodInvocationException.getMessage());
+
+    }
+
     @AfterEach
     public void tearDown() {
         springServerMethodInvokerDiscovery.close();